Linux RAID subsystem development
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: nenkov2004@gmail.com, linux-raid@vger.kernel.org, yukuai@fygo.io,
	song@kernel.org
Cc: dm-devel@lists.linux.dev, magiclinan@didiglobal.com,
	xiao@kernel.org, neil@brown.name, agk@redhat.com,
	snitzer@kernel.org, mpatocka@redhat.com, bmarzins@redhat.com,
	syzbot+8b22a0459202f76b4096@syzkaller.appspotmail.com
Subject: Re: [PATCH v2 1/2] dm raid: Clear MD_RECOVERY_WAIT on reshape setup failure
Date: Fri, 20 Nov 2026 11:22:44 +0000	[thread overview]
Message-ID: <sashiko-outbox-225029@kernel.org> (raw)
In-Reply-To: <20261120111757.4705-2-nenkov2004@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dm raid: missing Fixes trailer for rs_start_reshape() error
  cleanup
--

commit 6a83155083baad91c84f61814a141b78b22b8537
Author: Hristos Nenkov <nenkov2004@gmail.com>

> dm raid: Clear MD_RECOVERY_WAIT on reshape setup failure
>
> rs_start_reshape() sets MD_RECOVERY_WAIT to keep the sync thread
> from running before the table reload. If setup, check_reshape() or
> start_reshape() fails, raid_preresume() logs the error and continues
> without a reshape. There is no reshape-related table reload to wait for.
>
> Clear MD_RECOVERY_WAIT on those error paths. Keep the bit set when
> reshape setup succeeds.
>
> Suggested-by: Yu Kuai <yukuai@fygo.io>
> Link: https://lore.kernel.org/r/4d13edef-f454-437b-8910-3a905697303e@fygo.io
> Signed-off-by: Hristos Nenkov <nenkov2004@gmail.com>

[Severity: Low]
Commit 644e2537fdc7 ("dm raid: fix stripe adding reshape deadlock") added
set_bit(MD_RECOVERY_WAIT, &mddev->recovery) at the start of
rs_start_reshape() without clearing it on the error return paths.  Should
this include:

  Fixes: 644e2537fdc7 ("dm raid: fix stripe adding reshape deadlock")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120111757.4705-1-nenkov2004@gmail.com?part=1

  reply	other threads:[~2026-11-20 11:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6aec6738.059f5055.2712e4.0005.GAE@google.com>
2026-11-10  5:44 ` [PATCH] md/raid10: preserve recovery flags on reshape abort Hristos Nenkov
2026-11-20  7:05   ` yu kuai
2026-11-20 11:17     ` [PATCH v2 0/2] Fix recovery flags on failed RAID10 reshape nenkov2004
2026-11-20 11:17       ` [PATCH v2 1/2] dm raid: Clear MD_RECOVERY_WAIT on reshape setup failure nenkov2004
2026-11-20 11:22         ` sashiko-bot [this message]
2026-11-20 11:17       ` [PATCH v2 2/2] md/raid10: Preserve recovery flags on reshape abort nenkov2004

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225029@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agk@redhat.com \
    --cc=bmarzins@redhat.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=linux-raid@vger.kernel.org \
    --cc=magiclinan@didiglobal.com \
    --cc=mpatocka@redhat.com \
    --cc=neil@brown.name \
    --cc=nenkov2004@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=syzbot+8b22a0459202f76b4096@syzkaller.appspotmail.com \
    --cc=xiao@kernel.org \
    --cc=yukuai@fygo.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox