From: Li Nan <linan666@huaweicloud.com>
To: yukuai@fnnas.com, linan666@huaweicloud.com, song@kernel.org
Cc: xni@redhat.com, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org, yangerkun@huawei.com,
yi.zhang@huawei.com
Subject: Re: [PATCH v2 14/14] md/raid1,raid10: fall back to smaller order if sync folio alloc fails
Date: Thu, 5 Feb 2026 15:29:50 +0800 [thread overview]
Message-ID: <23035df1-d550-ee86-337c-e43847712e3c@huaweicloud.com> (raw)
In-Reply-To: <887aa7a7-0b74-4b92-a053-0f019bac7d85@fnnas.com>
在 2026/2/5 0:48, Yu Kuai 写道:
> Hi,
>
> 在 2026/1/28 15:57, linan666@huaweicloud.com 写道:
>> From: Li Nan <linan122@huawei.com>
>>
>> RESYNC_BLOCK_SIZE (64K) has higher allocation failure chance than 4k,
>> so retry with lower orders to improve allocation reliability.
>>
>> A r1/10_bio may have different rf->folio orders. Use minimum order as
>> r1/10_bio sectors to prevent exceeding size when adding folio to IO later.
>>
>> Signed-off-by: Li Nan <linan122@huawei.com>
>> ---
>> drivers/md/raid1-10.c | 14 +++++++++++---
>> drivers/md/raid1.c | 13 +++++++++----
>> drivers/md/raid10.c | 28 ++++++++++++++++++++++++++--
>> 3 files changed, 46 insertions(+), 9 deletions(-)
>
> Looks like this patch should be merged into patch 5, there is no need to introduce
> that higher allocation failure and then fix it here.
>
OK, I will merge abouve patches.
--
Thanks,
Nan
next prev parent reply other threads:[~2026-02-05 7:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 7:56 [PATCH v2 00/14] folio support for sync I/O in RAID linan666
2026-01-28 7:56 ` [PATCH v2 01/14] md/raid1,raid10: clean up of RESYNC_SECTORS linan666
2026-02-04 16:29 ` Yu Kuai
2026-01-28 7:56 ` [PATCH v2 02/14] md: introduce sync_folio_io for folio support in RAID linan666
2026-02-04 16:38 ` Yu Kuai
2026-01-28 7:56 ` [PATCH v2 03/14] md/raid1: use folio for tmppage linan666
2026-02-04 16:45 ` Yu Kuai
2026-02-05 7:23 ` Li Nan
2026-02-05 7:33 ` Yu Kuai
2026-02-06 9:07 ` Li Nan
2026-01-28 7:56 ` [PATCH v2 04/14] md/raid10: " linan666
2026-01-28 7:56 ` [PATCH v2 05/14] md/raid1,raid10: use folio for sync path IO linan666
2026-01-28 7:57 ` [PATCH v2 06/14] md: Clean up folio sync support related code linan666
2026-02-04 16:52 ` Yu Kuai
2026-02-05 7:27 ` Li Nan
2026-01-28 7:57 ` [PATCH v2 07/14] md/raid1: clean up useless sync_blocks handling in raid1_sync_request linan666
2026-01-28 7:57 ` [PATCH v2 08/14] md/raid1: fix IO error at logical block size granularity linan666
2026-02-04 16:54 ` Yu Kuai
2026-01-28 7:57 ` [PATCH v2 09/14] md/raid10: " linan666
2026-02-04 16:55 ` Yu Kuai
2026-01-28 7:57 ` [PATCH v2 10/14] md/raid1,raid10: clean up resync_fetch_folio linan666
2026-02-04 16:57 ` Yu Kuai
2026-01-28 7:57 ` [PATCH v2 11/14] md: clean up resync_free_folio linan666
2026-02-04 16:59 ` Yu Kuai
2026-01-28 7:57 ` [PATCH v2 12/14] md/raid1: clean up sync IO size calculation in raid1_sync_request linan666
2026-01-28 7:57 ` [PATCH v2 13/14] md/raid10: clean up sync IO size calculation in raid10_sync_request linan666
2026-01-28 7:57 ` [PATCH v2 14/14] md/raid1,raid10: fall back to smaller order if sync folio alloc fails linan666
2026-02-04 16:48 ` Yu Kuai
2026-02-05 7:29 ` Li Nan [this message]
2026-02-04 17:02 ` [PATCH v2 00/14] folio support for sync I/O in RAID Yu Kuai
2026-02-05 12:57 ` Li Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23035df1-d550-ee86-337c-e43847712e3c@huaweicloud.com \
--to=linan666@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai@fnnas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox