linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "NeilBrown" <neilb@suse.de>
To: Xu Yuehai <raid.yuehai@gmail.com>
Cc: linux-raid@vger.kernel.org, Trace Green <green.trace@gmail.com>
Subject: Re: Does raid5 have error handling while reading?
Date: Fri, 22 May 2009 18:35:48 +1000 (EST)	[thread overview]
Message-ID: <2bf95d5420210a8cab4700798fb6030c.squirrel@neil.brown.name> (raw)
In-Reply-To: <691c243c0905220110y541ab523v5998b8054c89da60@mail.gmail.com>

On Fri, May 22, 2009 6:10 pm, Xu Yuehai wrote:
> I know that if the read request of raid5 is handled by
> chunk_aligned_read, there is no error handling in raid5. But, if this
> read request is not aligned, that's say, raid5 need stripe_head to
> deal with this request. I find in the code of 2.6.27 that there is no
> error handling if this read request fail, I remember in older kernel,
> some operations should be done such as compute_block. Am I right?

If chunk_aligned_read results in an error, then the request
is re-tried through the stripe cache.  I would call that "error handling".

If the cache finds that a drives is failed, the data is calculated
from the other drives, though the code is not a straight forward
as it used to be.
See fetch_block5 which sets STRIPE_OP_COMPUTE_BLK which causes
ops_run_compute5 to do the work (or to schedule the work on separate
hardware).

NeilBrown


  reply	other threads:[~2009-05-22  8:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-22  8:10 Does raid5 have error handling while reading? Xu Yuehai
2009-05-22  8:35 ` NeilBrown [this message]
2009-05-22  9:13   ` Xu Yuehai
2009-05-22 11:21     ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bf95d5420210a8cab4700798fb6030c.squirrel@neil.brown.name \
    --to=neilb@suse.de \
    --cc=green.trace@gmail.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=raid.yuehai@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).