From: Xu Yuehai <raid.yuehai@gmail.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, green.trace@gmail.com
Subject: Re: Does raid5 have error handling while reading?
Date: Fri, 22 May 2009 17:13:59 +0800 [thread overview]
Message-ID: <691c243c0905220213i603ba115ga6aea27b7c564c1d@mail.gmail.com> (raw)
In-Reply-To: <2bf95d5420210a8cab4700798fb6030c.squirrel@neil.brown.name>
>
> If chunk_aligned_read results in an error, then the request
> is re-tried through the stripe cache. I would call that "error handling".
I think you mean that error() and raid5_align_endio are invoked and
the read request is sent to conf->retry_read_aligned_list, then the
raid5d will handle it.
> If the cache finds that a drives is failed, the data is calculated
> from the other drives, though the code is not a straight forward
> as it used to be.
> See fetch_block5 which sets STRIPE_OP_COMPUTE_BLK which causes
> ops_run_compute5 to do the work (or to schedule the work on separate
> hardware).
>
I notice that the bit STRIPE_OP_COMPUTE_BLK is set if only s->uptodate
== disks - 1, however, suppose there is just a single read request, I
fail to find out why this condition is satisfied.
Yuehai
next prev parent reply other threads:[~2009-05-22 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-22 8:10 Does raid5 have error handling while reading? Xu Yuehai
2009-05-22 8:35 ` NeilBrown
2009-05-22 9:13 ` Xu Yuehai [this message]
2009-05-22 11:21 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=691c243c0905220213i603ba115ga6aea27b7c564c1d@mail.gmail.com \
--to=raid.yuehai@gmail.com \
--cc=green.trace@gmail.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox