From: John Garry <john.g.garry@oracle.com>
To: Jens Axboe <axboe@kernel.dk>,
agk@redhat.com, snitzer@kernel.org, mpatocka@redhat.com,
song@kernel.org, yukuai3@huawei.com, hch@lst.de,
nilay@linux.ibm.com, cem@kernel.org
Cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
ojaswin@linux.ibm.com, martin.petersen@oracle.com,
akpm@linux-foundation.org, linux-xfs@vger.kernel.org,
djwong@kernel.org
Subject: Re: [PATCH v5 2/6] block: sanitize chunk_sectors for atomic write limits
Date: Thu, 10 Jul 2025 16:18:32 +0100 [thread overview]
Message-ID: <54d83775-7497-4fae-a9ea-bec8008557aa@oracle.com> (raw)
In-Reply-To: <04620cc5-7c3a-4e4f-87ce-b691d9b57917@kernel.dk>
On 10/07/2025 16:08, Jens Axboe wrote:
>> + chunk_bytes = lim->chunk_sectors << SECTOR_SHIFT;
>> + if (chunk_bytes) {
>> + if (WARN_ON_ONCE(lim->atomic_write_hw_unit_max >
>> + chunk_bytes))
>> + goto unsupported;
>> + }
> Unnecessary indentation here. Why not just:
>
> chunk_bytes = lim->chunk_sectors << SECTOR_SHIFT;
> if (WARN_ON_ONCE(chunk_bytes &&
> lim->atomic_write_hw_unit_max > chunk_bytes))
> goto unsupposed.
>
> Also avoids splitting a comparison over multiple lines, which is always
> annoying to read.
ok, I can tidy that up.
Thanks,
John
next prev parent reply other threads:[~2025-07-10 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 10:02 [PATCH v5 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size John Garry
2025-07-09 10:02 ` [PATCH v5 1/6] ilog2: add max_pow_of_two_factor() John Garry
2025-07-09 10:02 ` [PATCH v5 2/6] block: sanitize chunk_sectors for atomic write limits John Garry
2025-07-10 15:08 ` Jens Axboe
2025-07-10 15:18 ` John Garry [this message]
2025-07-09 10:02 ` [PATCH v5 3/6] md/raid0: set chunk_sectors limit John Garry
2025-07-09 10:02 ` [PATCH v5 4/6] md/raid10: " John Garry
2025-07-09 10:02 ` [PATCH v5 5/6] dm-stripe: limit chunk_sectors to the stripe size John Garry
2025-07-10 15:03 ` Mikulas Patocka
2025-07-10 15:29 ` John Garry
2025-07-09 10:02 ` [PATCH v5 6/6] block: use chunk_sectors when evaluating stacked atomic write limits John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54d83775-7497-4fae-a9ea-bec8008557aa@oracle.com \
--to=john.g.garry@oracle.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=dm-devel@lists.linux.dev \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mpatocka@redhat.com \
--cc=nilay@linux.ibm.com \
--cc=ojaswin@linux.ibm.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox