Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Mikulas Patocka <mpatocka@redhat.com>
To: John Garry <john.g.garry@oracle.com>
Cc: agk@redhat.com, snitzer@kernel.org, song@kernel.org,
	yukuai3@huawei.com,  hch@lst.de, nilay@linux.ibm.com,
	axboe@kernel.dk, cem@kernel.org,  dm-devel@lists.linux.dev,
	linux-kernel@vger.kernel.org,  linux-raid@vger.kernel.org,
	linux-block@vger.kernel.org,  ojaswin@linux.ibm.com,
	martin.petersen@oracle.com,  akpm@linux-foundation.org,
	linux-xfs@vger.kernel.org, djwong@kernel.org
Subject: Re: [PATCH v5 5/6] dm-stripe: limit chunk_sectors to the stripe size
Date: Thu, 10 Jul 2025 17:03:43 +0200 (CEST)	[thread overview]
Message-ID: <5e2bbd34-e112-c15a-37ea-f97cbede910c@redhat.com> (raw)
In-Reply-To: <20250709100238.2295112-6-john.g.garry@oracle.com>



On Wed, 9 Jul 2025, John Garry wrote:

> Same as done for raid0, set chunk_sectors limit to appropriately set the
> atomic write size limit.
> 
> Setting chunk_sectors limit in this way overrides the stacked limit
> already calculated based on the bottom device limits. This is ok, as
> when any bios are sent to the bottom devices, the block layer will still
> respect the bottom device chunk_sectors.
> 
> Reviewed-by: Nilay Shroff <nilay@linux.ibm.com>
> Reviewed-by: Mikulas Patocka <mpatocka@redhat.com>
> Signed-off-by: John Garry <john.g.garry@oracle.com>
> ---
>  drivers/md/dm-stripe.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c
> index a7dc04bd55e5..5bbbdf8fc1bd 100644
> --- a/drivers/md/dm-stripe.c
> +++ b/drivers/md/dm-stripe.c
> @@ -458,6 +458,7 @@ static void stripe_io_hints(struct dm_target *ti,
>  	struct stripe_c *sc = ti->private;
>  	unsigned int chunk_size = sc->chunk_size << SECTOR_SHIFT;
>  
> +	limits->chunk_sectors = sc->chunk_size;
>  	limits->io_min = chunk_size;
>  	limits->io_opt = chunk_size * sc->stripes;
>  }
> -- 
> 2.43.5

Hi

This will conflict with the current dm code in linux-dm.git. Should I fix 
up the conflict and commit it through the linux-dm git?

Mikulas


  reply	other threads:[~2025-07-10 15:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-09 10:02 [PATCH v5 0/6] block/md/dm: set chunk_sectors from stacked dev stripe size John Garry
2025-07-09 10:02 ` [PATCH v5 1/6] ilog2: add max_pow_of_two_factor() John Garry
2025-07-09 10:02 ` [PATCH v5 2/6] block: sanitize chunk_sectors for atomic write limits John Garry
2025-07-10 15:08   ` Jens Axboe
2025-07-10 15:18     ` John Garry
2025-07-09 10:02 ` [PATCH v5 3/6] md/raid0: set chunk_sectors limit John Garry
2025-07-09 10:02 ` [PATCH v5 4/6] md/raid10: " John Garry
2025-07-09 10:02 ` [PATCH v5 5/6] dm-stripe: limit chunk_sectors to the stripe size John Garry
2025-07-10 15:03   ` Mikulas Patocka [this message]
2025-07-10 15:29     ` John Garry
2025-07-09 10:02 ` [PATCH v5 6/6] block: use chunk_sectors when evaluating stacked atomic write limits John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e2bbd34-e112-c15a-37ea-f97cbede910c@redhat.com \
    --to=mpatocka@redhat.com \
    --cc=agk@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=john.g.garry@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nilay@linux.ibm.com \
    --cc=ojaswin@linux.ibm.com \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox