From: Heinz Mauelshagen <heinzm@redhat.com>
To: Andy Whitcroft <apw@canonical.com>
Cc: Mike Snitzer <snitzer@redhat.com>,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
dm-devel@redhat.com, Shaohua Li <shli@kernel.org>,
Alasdair Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation
Date: Tue, 11 Oct 2016 17:44:21 +0200 [thread overview]
Message-ID: <591b9d8d-2036-2d0f-14f2-af176b5beaea@redhat.com> (raw)
In-Reply-To: <20161011153808.nmyf6hafjaadcemw@brain>
On 10/11/2016 05:38 PM, Andy Whitcroft wrote:
> On Tue, Oct 11, 2016 at 05:04:34PM +0200, Heinz Mauelshagen wrote:
>> Andy,
>>
>> good catch.
>>
>> We should rather check for V190 support only in case any
>> compat feature flags are actually set.
>>
>> {
>> + if (le32_to_cpu(sb->compat_features) &&
>> + le32_to_cpu(sb->compat_features) != FEATURE_FLAG_SUPPORTS_V190)
>> {
>> rs->ti->error = "Unable to assemble array: Unknown flag(s)
>> in compatible feature flags";
>> return -EINVAL;
>> }
> If the feature flags are single bit combinations then I believe the
> below does check exactly that. Checking for no 1s outside of the
> expected features, caring not for the value of the valid bits:
>
> + if (le32_to_cpu(sb->compat_features) & ~(FEATURE_FLAG_SUPPORTS_V190)) {
>
> with the possibilty to or in additional feature bits as they are added.
Thanks,
I prefer this to be easier readable.
>
> -apw
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2016-10-11 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 14:28 [PATCH 1/1] dm raid: fix compat_features validation Andy Whitcroft
2016-10-11 15:04 ` [dm-devel] " Heinz Mauelshagen
2016-10-11 15:38 ` Andy Whitcroft
2016-10-11 15:44 ` Heinz Mauelshagen [this message]
2016-10-11 16:21 ` [PATCH 1/1 V2] " Andy Whitcroft
2016-10-11 16:53 ` Heinz Mauelshagen
2016-10-11 17:44 ` [PATCH 1/1] " Mike Snitzer
2016-10-14 17:14 ` Heinz Mauelshagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591b9d8d-2036-2d0f-14f2-af176b5beaea@redhat.com \
--to=heinzm@redhat.com \
--cc=agk@redhat.com \
--cc=apw@canonical.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox