From: "Guilherme G. Piccoli" <gpiccoli@canonical.com>
To: NeilBrown <neilb@suse.com>, linux-raid@vger.kernel.org
Cc: linux-block@vger.kernel.org, jay.vosburgh@canonical.com,
Song Liu <songliubraving@fb.com>,
dm-devel@redhat.com, Neil F Brown <nfbrown@suse.com>
Subject: Re: [PATCH] md/raid0: Fail BIOs if their underlying block device is gone
Date: Tue, 30 Jul 2019 09:30:31 -0300 [thread overview]
Message-ID: <6400083b-3cf3-cbc6-650a-c3ae6629b14c@canonical.com> (raw)
In-Reply-To: <87zhkwl6ya.fsf@notabene.neil.brown.name>
On 29/07/2019 21:08, NeilBrown wrote:
>[...]
>> + if (unlikely(test_bit(MD_BROKEN, &mddev->flags))) {
>> + bio_io_error(bio);
>> + return BLK_QC_T_NONE;
>> + }
>
> I think this should only fail WRITE requests, not READ requests.
>
> Otherwise the patch is probably reasonable.
>
> NeilBrown
Thanks for the feedback Neil! I thought about it; it seemed to me better
to deny/fail the reads instead of returning "wrong" reads, since a file
read in a raid0 will be incomplete if one member is missing.
But it's fine for me to change that in the next iteration of this patch.
Cheers,
Guilherme
next prev parent reply other threads:[~2019-07-30 12:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 19:33 [PATCH] md/raid0: Fail BIOs if their underlying block device is gone Guilherme G. Piccoli
2019-07-29 20:18 ` Roman Mamedov
2019-07-29 20:27 ` Guilherme G. Piccoli
2019-07-29 20:36 ` Roman Mamedov
2019-07-29 20:49 ` Guilherme G. Piccoli
2019-07-29 21:14 ` Reindl Harald
2019-07-30 0:08 ` NeilBrown
2019-07-30 12:30 ` Guilherme G. Piccoli [this message]
2019-07-31 19:54 ` Song Liu
2019-07-31 19:56 ` Song Liu
2019-08-01 20:28 ` Guilherme G. Piccoli
2019-08-01 22:43 ` Song Liu
2019-08-16 13:45 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6400083b-3cf3-cbc6-650a-c3ae6629b14c@canonical.com \
--to=gpiccoli@canonical.com \
--cc=dm-devel@redhat.com \
--cc=jay.vosburgh@canonical.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=nfbrown@suse.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox