From: Neil Brown <neilb@suse.com>
To: linux-raid@vger.kernel.org
Cc: Song Liu <songliubraving@fb.com>, shli@fb.com
Subject: Re: [PATCH] MD: fix missing cpu_to_le32 for MD_FEATURE_JOURNAL
Date: Thu, 15 Oct 2015 17:37:06 +1100 [thread overview]
Message-ID: <87d1wgwsbx.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <1444888404-994890-1-git-send-email-songliubraving@fb.com>
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
Song Liu <songliubraving@fb.com> writes:
> sb->feature_map is __le32, add missing cpu_to_le32()
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Song Liu <songliubraving@fb.com>
> ---
> drivers/md/md.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 378b9f0..163b548 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -1812,7 +1812,7 @@ retry:
> sb->dev_roles[i] = cpu_to_le16(MD_DISK_ROLE_FAULTY);
>
> if (test_bit(MD_HAS_JOURNAL, &mddev->flags))
> - sb->feature_map |= MD_FEATURE_JOURNAL;
> + sb->feature_map |= cpu_to_le32(MD_FEATURE_JOURNAL);
>
> rdev_for_each(rdev2, mddev) {
> i = rdev2->desc_nr;
> --
> 2.4.6
Thanks.
I just emrged this in rather than create a new patch.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-10-15 6:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 5:53 [PATCH] MD: fix missing cpu_to_le32 for MD_FEATURE_JOURNAL Song Liu
2015-10-15 6:37 ` Neil Brown [this message]
2015-10-15 6:54 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1wgwsbx.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=shli@fb.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox