* [PATCH] MD: fix missing cpu_to_le32 for MD_FEATURE_JOURNAL
@ 2015-10-15 5:53 Song Liu
2015-10-15 6:37 ` Neil Brown
0 siblings, 1 reply; 3+ messages in thread
From: Song Liu @ 2015-10-15 5:53 UTC (permalink / raw)
To: linux-raid; +Cc: Song Liu, neilb, shli
sb->feature_map is __le32, add missing cpu_to_le32()
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
---
drivers/md/md.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 378b9f0..163b548 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -1812,7 +1812,7 @@ retry:
sb->dev_roles[i] = cpu_to_le16(MD_DISK_ROLE_FAULTY);
if (test_bit(MD_HAS_JOURNAL, &mddev->flags))
- sb->feature_map |= MD_FEATURE_JOURNAL;
+ sb->feature_map |= cpu_to_le32(MD_FEATURE_JOURNAL);
rdev_for_each(rdev2, mddev) {
i = rdev2->desc_nr;
--
2.4.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] MD: fix missing cpu_to_le32 for MD_FEATURE_JOURNAL
2015-10-15 5:53 [PATCH] MD: fix missing cpu_to_le32 for MD_FEATURE_JOURNAL Song Liu
@ 2015-10-15 6:37 ` Neil Brown
2015-10-15 6:54 ` Song Liu
0 siblings, 1 reply; 3+ messages in thread
From: Neil Brown @ 2015-10-15 6:37 UTC (permalink / raw)
To: linux-raid; +Cc: Song Liu, shli
[-- Attachment #1: Type: text/plain, Size: 843 bytes --]
Song Liu <songliubraving@fb.com> writes:
> sb->feature_map is __le32, add missing cpu_to_le32()
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Song Liu <songliubraving@fb.com>
> ---
> drivers/md/md.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 378b9f0..163b548 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -1812,7 +1812,7 @@ retry:
> sb->dev_roles[i] = cpu_to_le16(MD_DISK_ROLE_FAULTY);
>
> if (test_bit(MD_HAS_JOURNAL, &mddev->flags))
> - sb->feature_map |= MD_FEATURE_JOURNAL;
> + sb->feature_map |= cpu_to_le32(MD_FEATURE_JOURNAL);
>
> rdev_for_each(rdev2, mddev) {
> i = rdev2->desc_nr;
> --
> 2.4.6
Thanks.
I just emrged this in rather than create a new patch.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] MD: fix missing cpu_to_le32 for MD_FEATURE_JOURNAL
2015-10-15 6:37 ` Neil Brown
@ 2015-10-15 6:54 ` Song Liu
0 siblings, 0 replies; 3+ messages in thread
From: Song Liu @ 2015-10-15 6:54 UTC (permalink / raw)
To: Neil Brown, linux-raid@vger.kernel.org; +Cc: Shaohua Li
> -----Original Message-----
> From: Neil Brown [mailto:neilb@suse.com]
> Sent: Wednesday, October 14, 2015 11:37 PM
> To: Song Liu <songliubraving@fb.com>; linux-raid@vger.kernel.org
> Cc: Song Liu <songliubraving@fb.com>; Shaohua Li <shli@fb.com>
> Subject: Re: [PATCH] MD: fix missing cpu_to_le32 for
> MD_FEATURE_JOURNAL
>
> Song Liu <songliubraving@fb.com> writes:
>
> > sb->feature_map is __le32, add missing cpu_to_le32()
> >
> > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > Signed-off-by: Song Liu <songliubraving@fb.com>
> > ---
> > drivers/md/md.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/md/md.c b/drivers/md/md.c index 378b9f0..163b548
> > 100644
> > --- a/drivers/md/md.c
> > +++ b/drivers/md/md.c
> > @@ -1812,7 +1812,7 @@ retry:
> > sb->dev_roles[i] = cpu_to_le16(MD_DISK_ROLE_FAULTY);
> >
> > if (test_bit(MD_HAS_JOURNAL, &mddev->flags))
> > - sb->feature_map |= MD_FEATURE_JOURNAL;
> > + sb->feature_map |= cpu_to_le32(MD_FEATURE_JOURNAL);
> >
> > rdev_for_each(rdev2, mddev) {
> > i = rdev2->desc_nr;
> > --
> > 2.4.6
>
> Thanks.
> I just emrged this in rather than create a new patch.
>
> NeilBrown
That's awesome!
Thanks,
Song
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-15 6:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-15 5:53 [PATCH] MD: fix missing cpu_to_le32 for MD_FEATURE_JOURNAL Song Liu
2015-10-15 6:37 ` Neil Brown
2015-10-15 6:54 ` Song Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox