From: "Kay Sievers" <kay.sievers@vrfy.org>
To: Dan Williams <dan.j.williams@intel.com>
Cc: NeilBrown <neilb@suse.de>, linux-raid <linux-raid@vger.kernel.org>
Subject: Re: [mdadm git pull] support for detecting platform raid capabilities and some fixes
Date: Thu, 27 Nov 2008 01:13:29 +0100 [thread overview]
Message-ID: <ac3eb2510811261613ja5bc80ag4fc011d76d95e961@mail.gmail.com> (raw)
In-Reply-To: <1227743100.31146.41.camel@dwillia2-linux.ch.intel.com>
On Thu, Nov 27, 2008 at 00:45, Dan Williams <dan.j.williams@intel.com> wrote:
> This is hopefully the tail of the feature additions from me for
> mdadm-3.0-final. It adds the capability for mdadm to detect platform
> raid capabilities, and honor them when creating new arrays.
> This implementation crawls through sysfs to put this information
> together, I believe it is crawling in a future proof fashion, but here
> are my assumptions:
> 1/ /sys/bus/pci/drivers/ahci/<x>/device will identify a pci ahci device
Why "device"? You just check for the "device" attribute file of the PCI device?
> 1/ An attempt to cover the delay between mdadm creating an array and the
> friendly-named device node showing up in /dev/md/ by calling 'udevadm
> settle' before starting starting Incremental assembly. This
> specifically fixes scripts that do:
> mdadm -A /dev/md/<container>
> mdadm -I /dev/md/<container>
> There is a good chance there is a better place to put this call, but
> putting it in create_mddev didn't work, and moving it up in main()
> resulted in a hang. I didn't want to hold up the other patches for this
> debug.
If mdadm calls "udevadm settle", we can not call mdadm (which we do
already) from udev rules because it will just deadlock.
We need to make "udevadm settle" smarter and not to wait for its own
event, or make it wait for something specific and not just "all"
events, or find a different way for mdadm to sync with udev.
Thanks,
Kay
next prev parent reply other threads:[~2008-11-27 0:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 23:45 [mdadm git pull] support for detecting platform raid capabilities and some fixes Dan Williams
2008-11-27 0:13 ` Kay Sievers [this message]
2008-11-27 3:25 ` Dan Williams
2008-11-27 6:24 ` Kay Sievers
2008-11-28 17:24 ` Dan Williams
2008-11-27 23:39 ` Neil Brown
2008-11-28 19:16 ` Dan Williams
2008-12-02 6:18 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac3eb2510811261613ja5bc80ag4fc011d76d95e961@mail.gmail.com \
--to=kay.sievers@vrfy.org \
--cc=dan.j.williams@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox