Linux RAID subsystem development
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Mikulas Patocka <mpatocka@redhat.com>,
	axboe@kernel.dk, agk@redhat.com, snitzer@kernel.org,
	song@kernel.org, yukuai3@huawei.com, hch@lst.de,
	nilay@linux.ibm.com, dm-devel@lists.linux.dev,
	linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-block@vger.kernel.org, ojaswin@linux.ibm.com
Subject: Re: [PATCH v3 5/5] block: use chunk_sectors when evaluating stacked atomic write limits
Date: Mon, 21 Jul 2025 15:09:24 +0100	[thread overview]
Message-ID: <cad33609-9a92-444b-9ff5-5f5a68598866@oracle.com> (raw)
In-Reply-To: <yq1a55edu8i.fsf@ca-mkp.ca.oracle.com>

On 09/07/2025 02:39, Martin K. Petersen wrote:
> The intent for io_min was to convey the physical_block_size in the case
> of an individual drive. And for it to be set to the stripe chunk size in
> stacking scenarios that would otherwise involve read-modify-write (i.e.
> RAID5 and RAID6).
> 
> io_opt was meant to communicate the stripe width. Reporting very large
> values for io_opt is generally counterproductive since we can't write
> multiple gigabytes in a single operation anyway.
> 
> logical <= physical <= io_min <= io_opt <= max_sectors <= max_hw_sectors

Does pbs need to be a power-of-2?

The block queue limits and splitting code seems to rely on that, but it 
is not policed AFAICS.

The stacking code seems to just want it to be a multiple of lbs, which 
itself must be a power-of-2.

Thanks,
John

  parent reply	other threads:[~2025-07-21 14:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-03 11:46 [PATCH v3 0/5] block/md/dm: set chunk_sectors from stacked dev stripe size John Garry
2025-07-03 11:46 ` [PATCH v3 1/5] block: sanitize chunk_sectors for atomic write limits John Garry
2025-07-03 11:46 ` [PATCH v3 2/5] md/raid0: set chunk_sectors limit John Garry
2025-07-03 11:46 ` [PATCH v3 3/5] md/raid10: " John Garry
2025-07-03 11:46 ` [PATCH v3 4/5] dm-stripe: limit chunk_sectors to the stripe size John Garry
2025-07-03 11:46 ` [PATCH v3 5/5] block: use chunk_sectors when evaluating stacked atomic write limits John Garry
2025-07-03 13:31   ` Mikulas Patocka
2025-07-03 14:17     ` John Garry
2025-07-03 15:36       ` Mikulas Patocka
2025-07-03 16:01         ` John Garry
2025-07-09  1:39           ` Martin K. Petersen
2025-07-09 13:16             ` John Garry
2025-07-21 14:09             ` John Garry [this message]
2025-07-22  3:43               ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cad33609-9a92-444b-9ff5-5f5a68598866@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=agk@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=dm-devel@lists.linux.dev \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mpatocka@redhat.com \
    --cc=nilay@linux.ibm.com \
    --cc=ojaswin@linux.ibm.com \
    --cc=snitzer@kernel.org \
    --cc=song@kernel.org \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox