From: Doug Ledford <dledford@redhat.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Bernard Metzler <bmt@zurich.ibm.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH 1/1] Make user mmapped CQ arming flags field 32 bit size to remove 64 bit architecture dependency of siw.
Date: Tue, 06 Aug 2019 08:32:50 -0400 [thread overview]
Message-ID: <044973ce7080eb5274befb99aab457897d577c96.camel@redhat.com> (raw)
In-Reply-To: <20190806121006.GC11627@ziepe.ca>
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
On Tue, 2019-08-06 at 09:10 -0300, Jason Gunthorpe wrote:
> On Mon, Aug 05, 2019 at 04:17:08PM +0200, Bernard Metzler wrote:
> > Signed-off-by: Bernard Metzler <bmt@zurich.ibm.com>
> > ---
>
> Don't send patches with empty commit messages. Every patch must have a
> comprehensive commit message from now on.
>
> > drivers/infiniband/sw/siw/Kconfig | 2 +-
> > drivers/infiniband/sw/siw/siw.h | 2 +-
> > drivers/infiniband/sw/siw/siw_qp.c | 14 ++++++++++----
He had a decent commit log message, it was just in the cover letter.
Bernard, on single patch submissions, skip the cover letter and just
send the patch by itself. Then the nice explanation you gave in the
cover letter should go in the commit message itself.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-08-06 12:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 14:17 [PATCH 0/1] Fix siw CQ processing for 32 bit archtecture support Bernard Metzler
2019-08-05 14:17 ` [PATCH 1/1] Make user mmapped CQ arming flags field 32 bit size to remove 64 bit architecture dependency of siw Bernard Metzler
2019-08-05 17:09 ` Leon Romanovsky
2019-08-06 11:58 ` Bernard Metzler
2019-08-06 12:10 ` Jason Gunthorpe
2019-08-06 12:32 ` Doug Ledford [this message]
2019-08-06 13:09 ` Bernard Metzler
2019-08-06 14:53 ` Bernard Metzler
2019-08-06 15:31 ` Jason Gunthorpe
2019-08-06 16:36 ` Bernard Metzler
2019-08-06 16:39 ` Jason Gunthorpe
2019-08-06 17:01 ` Bernard Metzler
2019-08-06 17:35 ` Jason Gunthorpe
2019-08-07 17:49 ` Bernard Metzler
2019-08-07 18:53 ` Doug Ledford
2019-08-08 14:17 ` Bernard Metzler
2019-08-08 15:39 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=044973ce7080eb5274befb99aab457897d577c96.camel@redhat.com \
--to=dledford@redhat.com \
--cc=bmt@zurich.ibm.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox