From: Jason Gunthorpe <jgg@ziepe.ca>
To: Bernard Metzler <BMT@zurich.ibm.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: Re: [PATCH 1/1] Make user mmapped CQ arming flags field 32 bit size to remove 64 bit architecture dependency of siw.
Date: Tue, 6 Aug 2019 12:31:05 -0300 [thread overview]
Message-ID: <20190806153105.GG11627@ziepe.ca> (raw)
In-Reply-To: <OFCF70B144.E0186C06-ON0025844E.0050E500-0025844E.0051D4FA@notes.na.collabserv.com>
On Tue, Aug 06, 2019 at 02:53:49PM +0000, Bernard Metzler wrote:
> >> index 7de68f1dc707..af735f55b291 100644
> >> +++ b/include/uapi/rdma/siw-abi.h
> >> @@ -180,6 +180,7 @@ struct siw_cqe {
> >> * to control CQ arming.
> >> */
> >> struct siw_cq_ctrl {
> >> - __aligned_u64 notify;
> >> + __u32 flags;
> >> + __u32 pad;
> >
> >The commit message needs to explain why this is compatible with
> >existing user space, if it is even is safe..
> >
> Old libsiw would remain compatible with the new layout, since it
> simply reads the 32bit 'flags' and zeroed 32bit 'pad' into a 64bit
> 'notify', ending with reading the same bits.
Even on big endian?
Jason
next prev parent reply other threads:[~2019-08-06 15:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 14:17 [PATCH 0/1] Fix siw CQ processing for 32 bit archtecture support Bernard Metzler
2019-08-05 14:17 ` [PATCH 1/1] Make user mmapped CQ arming flags field 32 bit size to remove 64 bit architecture dependency of siw Bernard Metzler
2019-08-05 17:09 ` Leon Romanovsky
2019-08-06 11:58 ` Bernard Metzler
2019-08-06 12:10 ` Jason Gunthorpe
2019-08-06 12:32 ` Doug Ledford
2019-08-06 13:09 ` Bernard Metzler
2019-08-06 14:53 ` Bernard Metzler
2019-08-06 15:31 ` Jason Gunthorpe [this message]
2019-08-06 16:36 ` Bernard Metzler
2019-08-06 16:39 ` Jason Gunthorpe
2019-08-06 17:01 ` Bernard Metzler
2019-08-06 17:35 ` Jason Gunthorpe
2019-08-07 17:49 ` Bernard Metzler
2019-08-07 18:53 ` Doug Ledford
2019-08-08 14:17 ` Bernard Metzler
2019-08-08 15:39 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806153105.GG11627@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=BMT@zurich.ibm.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox