Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
* [PATCH rdma-next 1/1] RDMA/mana_ib: Allocate PAGE aligned doorbell index
@ 2025-02-05 10:30 Konstantin Taranov
  2025-02-05 19:02 ` Long Li
  2025-02-06  9:03 ` Leon Romanovsky
  0 siblings, 2 replies; 3+ messages in thread
From: Konstantin Taranov @ 2025-02-05 10:30 UTC (permalink / raw)
  To: kotaranov, shirazsaleem, sharmaajay, longli, jgg, leon
  Cc: linux-rdma, linux-kernel

From: Konstantin Taranov <kotaranov@microsoft.com>

Allocate a PAGE aligned doorbell index to ensure each process gets a
separate PAGE sized doorbell area space remapped to it in mana_ib_mmap

Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter")
Signed-off-by: Shiraz Saleem <shirazsaleem@microsoft.com>
Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
---
 drivers/infiniband/hw/mana/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mana/main.c b/drivers/infiniband/hw/mana/main.c
index ae1fb69..0b89fa0 100644
--- a/drivers/infiniband/hw/mana/main.c
+++ b/drivers/infiniband/hw/mana/main.c
@@ -177,7 +177,7 @@ static int mana_gd_allocate_doorbell_page(struct gdma_context *gc,
 
 	req.resource_type = GDMA_RESOURCE_DOORBELL_PAGE;
 	req.num_resources = 1;
-	req.alignment = 1;
+	req.alignment = PAGE_SIZE / MANA_PAGE_SIZE;
 
 	/* Have GDMA start searching from 0 */
 	req.allocated_resources = 0;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH rdma-next 1/1] RDMA/mana_ib: Allocate PAGE aligned doorbell index
  2025-02-05 10:30 [PATCH rdma-next 1/1] RDMA/mana_ib: Allocate PAGE aligned doorbell index Konstantin Taranov
@ 2025-02-05 19:02 ` Long Li
  2025-02-06  9:03 ` Leon Romanovsky
  1 sibling, 0 replies; 3+ messages in thread
From: Long Li @ 2025-02-05 19:02 UTC (permalink / raw)
  To: Konstantin Taranov, Konstantin Taranov, Shiraz Saleem,
	sharmaajay@microsoft.com, jgg@ziepe.ca, leon@kernel.org
  Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org

> Subject: [PATCH rdma-next 1/1] RDMA/mana_ib: Allocate PAGE aligned doorbell
> index
> 
> From: Konstantin Taranov <kotaranov@microsoft.com>
> 
> Allocate a PAGE aligned doorbell index to ensure each process gets a separate
> PAGE sized doorbell area space remapped to it in mana_ib_mmap
> 
> Fixes: 0266a177631d ("RDMA/mana_ib: Add a driver for Microsoft Azure
> Network Adapter")
> Signed-off-by: Shiraz Saleem <shirazsaleem@microsoft.com>
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>

Reviewed-by: Long Li <longli@microsoft.com>

> ---
>  drivers/infiniband/hw/mana/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mana/main.c
> b/drivers/infiniband/hw/mana/main.c
> index ae1fb69..0b89fa0 100644
> --- a/drivers/infiniband/hw/mana/main.c
> +++ b/drivers/infiniband/hw/mana/main.c
> @@ -177,7 +177,7 @@ static int mana_gd_allocate_doorbell_page(struct
> gdma_context *gc,
> 
>  	req.resource_type = GDMA_RESOURCE_DOORBELL_PAGE;
>  	req.num_resources = 1;
> -	req.alignment = 1;
> +	req.alignment = PAGE_SIZE / MANA_PAGE_SIZE;
> 
>  	/* Have GDMA start searching from 0 */
>  	req.allocated_resources = 0;
> --
> 2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH rdma-next 1/1] RDMA/mana_ib: Allocate PAGE aligned doorbell index
  2025-02-05 10:30 [PATCH rdma-next 1/1] RDMA/mana_ib: Allocate PAGE aligned doorbell index Konstantin Taranov
  2025-02-05 19:02 ` Long Li
@ 2025-02-06  9:03 ` Leon Romanovsky
  1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2025-02-06  9:03 UTC (permalink / raw)
  To: kotaranov, shirazsaleem, sharmaajay, longli, jgg,
	Konstantin Taranov
  Cc: linux-rdma, linux-kernel


On Wed, 05 Feb 2025 02:30:05 -0800, Konstantin Taranov wrote:
> Allocate a PAGE aligned doorbell index to ensure each process gets a
> separate PAGE sized doorbell area space remapped to it in mana_ib_mmap
> 
> 

Applied, thanks!

[1/1] RDMA/mana_ib: Allocate PAGE aligned doorbell index
      https://git.kernel.org/rdma/rdma/c/29b7bb98234cc2

Best regards,
-- 
Leon Romanovsky <leon@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-06  9:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-05 10:30 [PATCH rdma-next 1/1] RDMA/mana_ib: Allocate PAGE aligned doorbell index Konstantin Taranov
2025-02-05 19:02 ` Long Li
2025-02-06  9:03 ` Leon Romanovsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox