* [PATCH net RESEND] net/mlx5: Fill out devlink dev info only for PFs
@ 2025-03-06 21:25 Tariq Toukan
2025-03-07 3:41 ` Parav Pandit
2025-03-08 3:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Tariq Toukan @ 2025-03-06 21:25 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, Paolo Abeni, Eric Dumazet,
Andrew Lunn
Cc: Saeed Mahameed, Gal Pressman, Leon Romanovsky, Mark Bloch,
Jiri Pirko, Leon Romanovsky, Tariq Toukan, netdev, linux-rdma,
linux-kernel, Jiri Pirko, Kalesh AP
From: Jiri Pirko <jiri@nvidia.com>
Firmware version query is supported on the PFs. Due to this
following kernel warning log is observed:
[ 188.590344] mlx5_core 0000:08:00.2: mlx5_fw_version_query:816:(pid 1453): fw query isn't supported by the FW
Fix it by restricting the query and devlink info to the PF.
Fixes: 8338d9378895 ("net/mlx5: Added devlink info callback")
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
index 98d4306929f3..a2cf3e79693d 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
@@ -46,6 +46,9 @@ mlx5_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req,
u32 running_fw, stored_fw;
int err;
+ if (!mlx5_core_is_pf(dev))
+ return 0;
+
err = devlink_info_version_fixed_put(req, "fw.psid", dev->board_id);
if (err)
return err;
--
2.45.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH net RESEND] net/mlx5: Fill out devlink dev info only for PFs
2025-03-06 21:25 [PATCH net RESEND] net/mlx5: Fill out devlink dev info only for PFs Tariq Toukan
@ 2025-03-07 3:41 ` Parav Pandit
2025-03-08 3:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Parav Pandit @ 2025-03-07 3:41 UTC (permalink / raw)
To: Tariq Toukan, David S. Miller, Jakub Kicinski, Paolo Abeni,
Eric Dumazet, Andrew Lunn
Cc: Saeed Mahameed, Gal Pressman, Leon Romanovsky, Mark Bloch,
Jiri Pirko, Leon Romanovsky, Tariq Toukan, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Pirko, Kalesh AP
> From: Tariq Toukan <tariqt@nvidia.com>
> Sent: Friday, March 7, 2025 2:55 AM
>
> From: Jiri Pirko <jiri@nvidia.com>
>
> Firmware version query is supported on the PFs. Due to this following kernel
> warning log is observed:
>
> [ 188.590344] mlx5_core 0000:08:00.2: mlx5_fw_version_query:816:(pid
> 1453): fw query isn't supported by the FW
>
> Fix it by restricting the query and devlink info to the PF.
>
> Fixes: 8338d9378895 ("net/mlx5: Added devlink info callback")
> Signed-off-by: Jiri Pirko <jiri@nvidia.com>
> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Reviewed-by: Parav Pandit <parav@nvidia.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> index 98d4306929f3..a2cf3e79693d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> @@ -46,6 +46,9 @@ mlx5_devlink_info_get(struct devlink *devlink, struct
> devlink_info_req *req,
> u32 running_fw, stored_fw;
> int err;
>
> + if (!mlx5_core_is_pf(dev))
> + return 0;
> +
> err = devlink_info_version_fixed_put(req, "fw.psid", dev->board_id);
> if (err)
> return err;
> --
> 2.45.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net RESEND] net/mlx5: Fill out devlink dev info only for PFs
2025-03-06 21:25 [PATCH net RESEND] net/mlx5: Fill out devlink dev info only for PFs Tariq Toukan
2025-03-07 3:41 ` Parav Pandit
@ 2025-03-08 3:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-03-08 3:50 UTC (permalink / raw)
To: Tariq Toukan
Cc: davem, kuba, pabeni, edumazet, andrew+netdev, saeedm, gal, leonro,
mbloch, jiri, leon, netdev, linux-rdma, linux-kernel, jiri,
kalesh-anakkur.purayil
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 6 Mar 2025 23:25:29 +0200 you wrote:
> From: Jiri Pirko <jiri@nvidia.com>
>
> Firmware version query is supported on the PFs. Due to this
> following kernel warning log is observed:
>
> [ 188.590344] mlx5_core 0000:08:00.2: mlx5_fw_version_query:816:(pid 1453): fw query isn't supported by the FW
>
> [...]
Here is the summary with links:
- [net,RESEND] net/mlx5: Fill out devlink dev info only for PFs
https://git.kernel.org/netdev/net/c/d749d901b216
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-08 3:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-06 21:25 [PATCH net RESEND] net/mlx5: Fill out devlink dev info only for PFs Tariq Toukan
2025-03-07 3:41 ` Parav Pandit
2025-03-08 3:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox