[PATCH rdma-rc] RDMA/bnxt_re: Avoid clearing VLAN_ID mask in modify qp path

[PATCH rdma-rc] RDMA/bnxt_re: Avoid clearing VLAN_ID mask in modify qp path

[Selvin Xavier]

From: Saravanan Vajravel <saravanan.vajravel@broadcom.com>

Driver is always clearing the mask that sets the VLAN ID/Service Level
in the adapter. Recent change for supporting multiple traffic class
exposed this issue.

Allow setting SL and VLAN_ID while QP is moved from INIT to RTR state.

Fixes: 1ac5a4047975 ("RDMA/bnxt_re: Add bnxt_re RoCE driver")
Fixes: c64b16a37b6d ("RDMA/bnxt_re: Support different traffic class")
Signed-off-by: Saravanan Vajravel <saravanan.vajravel@broadcom.com>
Signed-off-by: Selvin Xavier <selvin.xavier@broadcom.com>
---
 drivers/infiniband/hw/bnxt_re/qplib_fp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
index 5336f74..457eecb 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
@@ -1217,8 +1217,6 @@ static void __modify_flags_from_init_state(struct bnxt_qplib_qp *qp)
 			qp->path_mtu =
 				CMDQ_MODIFY_QP_PATH_MTU_MTU_2048;
 		}
-		qp->modify_flags &=
-			~CMDQ_MODIFY_QP_MODIFY_MASK_VLAN_ID;
 		/* Bono FW require the max_dest_rd_atomic to be >= 1 */
 		if (qp->max_dest_rd_atomic < 1)
 			qp->max_dest_rd_atomic = 1;
-- 
2.5.5

Re: [PATCH rdma-rc] RDMA/bnxt_re: Avoid clearing VLAN_ID mask in modify qp path

[Leon Romanovsky]

On Mon, 10 Mar 2025 22:16:36 -0700, Selvin Xavier wrote:
> Driver is always clearing the mask that sets the VLAN ID/Service Level
> in the adapter. Recent change for supporting multiple traffic class
> exposed this issue.
> 
> Allow setting SL and VLAN_ID while QP is moved from INIT to RTR state.
> 
> 
> [...]

Applied, thanks!

[1/1] RDMA/bnxt_re: Avoid clearing VLAN_ID mask in modify qp path
      https://git.kernel.org/rdma/rdma/c/81c0db302a674f

Best regards,
-- 
Leon Romanovsky <leon@kernel.org>