* [PATCH] RDMA/mlx5: use QP port when decoding responder CQEs
@ 2026-04-10 7:40 Chenguang Zhao
2026-05-10 15:55 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Chenguang Zhao @ 2026-04-10 7:40 UTC (permalink / raw)
To: Leon Romanovsky, Jason Gunthorpe; +Cc: Chenguang Zhao, linux-rdma
The responder CQE path determines the link layer via
rdma_port_get_link_layer(). Use qp->port instead of
hardcoding port 1, which can mis-decode completions on
multi-port devices.
Signed-off-by: Chenguang Zhao <zhaochenguang@kylinos.cn>
---
drivers/infiniband/hw/mlx5/cq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx5/cq.c b/drivers/infiniband/hw/mlx5/cq.c
index d0cd3f805bcb..2481b3361c1d 100644
--- a/drivers/infiniband/hw/mlx5/cq.c
+++ b/drivers/infiniband/hw/mlx5/cq.c
@@ -169,7 +169,8 @@ enum {
static void handle_responder(struct ib_wc *wc, struct mlx5_cqe64 *cqe,
struct mlx5_ib_qp *qp)
{
- enum rdma_link_layer ll = rdma_port_get_link_layer(qp->ibqp.device, 1);
+ enum rdma_link_layer ll =
+ rdma_port_get_link_layer(qp->ibqp.device, qp->port);
struct mlx5_ib_dev *dev = to_mdev(qp->ibqp.device);
struct mlx5_ib_srq *srq = NULL;
struct mlx5_ib_wq *wq;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] RDMA/mlx5: use QP port when decoding responder CQEs
2026-04-10 7:40 [PATCH] RDMA/mlx5: use QP port when decoding responder CQEs Chenguang Zhao
@ 2026-05-10 15:55 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2026-05-10 15:55 UTC (permalink / raw)
To: Jason Gunthorpe, Chenguang Zhao; +Cc: linux-rdma
On Fri, 10 Apr 2026 15:40:46 +0800, Chenguang Zhao wrote:
> The responder CQE path determines the link layer via
> rdma_port_get_link_layer(). Use qp->port instead of
> hardcoding port 1, which can mis-decode completions on
> multi-port devices.
Applied, thanks!
[1/1] RDMA/mlx5: use QP port when decoding responder CQEs
https://git.kernel.org/rdma/rdma/c/1a1ead4b27d3b5
Best regards,
--
Leon Romanovsky <leon@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-10 15:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-10 7:40 [PATCH] RDMA/mlx5: use QP port when decoding responder CQEs Chenguang Zhao
2026-05-10 15:55 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox