From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>,
Yishai Hadas <yishaih@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
lirongqing <lirongqing@baidu.com>
Subject: Re: [PATCH v2] RDMA/uverbs: Make CQ handle mandatory for WQ creation
Date: Tue, 15 Sep 2026 07:16:26 -0400 [thread overview]
Message-ID: <178947098678.1230106.15681890155815264544.b4-ty@kernel.org> (raw)
In-Reply-To: <20260911021557.2113-1-lirongqing@baidu.com>
On Fri, 11 Sep 2026 10:15:57 +0800, lirongqing wrote:
> UVERBS_ATTR_CREATE_WQ_CQ_HANDLE is declared UA_OPTIONAL in the ioctl
> method definition, so the mandatory attribute bitmap does not enforce
> its presence. When userspace omits it, uverbs_attr_get_obj() returns
> ERR_PTR(-ENOENT) and the handler stores that error pointer into
> wq_init_attr.cq without validation.
>
> The bogus cq pointer is then passed to the driver's create_wq callback.
> In the mlx5 case, create_rq() calls to_mcq(init_attr->cq) which applies
> container_of to the ERR_PTR value, producing a near-NULL pointer. The
> subsequent access in get_rq_ts_format() triggers a kernel NULL pointer
> dereference:
>
> [...]
Applied, thanks!
[1/1] RDMA/uverbs: Make CQ handle mandatory for WQ creation
https://git.kernel.org/rdma/rdma/c/f7d28791433d37
Best regards,
--
Leon Romanovsky <leon@kernel.org>
prev parent reply other threads:[~2026-09-15 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 2:15 [PATCH v2] RDMA/uverbs: Make CQ handle mandatory for WQ creation lirongqing
2026-09-11 2:29 ` sashiko-bot
2026-09-11 3:06 ` Kalesh Anakkur Purayil
2026-09-15 11:16 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178947098678.1230106.15681890155815264544.b4-ty@kernel.org \
--to=leon@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox