From: Matthias May <matthias.may@westermo.com>
To: Guillaume Nault <gnault@redhat.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<roopa@nvidia.com>, <eng.alaamohamedsoliman.am@gmail.com>,
<bigeasy@linutronix.de>, <saeedm@nvidia.com>, <leon@kernel.org>,
<roid@nvidia.com>, <maord@nvidia.com>, <lariel@nvidia.com>,
<vladbu@nvidia.com>, <cmi@nvidia.com>, <yoshfuji@linux-ipv6.org>,
<dsahern@kernel.org>, <linux-kernel@vger.kernel.org>,
<bpf@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
<nicolas.dichtel@6wind.com>, <eyal.birger@gmail.com>,
<jesse@nicira.com>, <linville@tuxdriver.com>,
<daniel@iogearbox.net>, <hadarh@mellanox.com>,
<ogerlitz@mellanox.com>, <willemb@google.com>,
<martin.varghese@nokia.com>
Subject: Re: [PATCH v2 net 1/4] geneve: do not use RT_TOS for IPv6 flowlabel
Date: Wed, 3 Aug 2022 14:40:41 +0200 [thread overview]
Message-ID: <19ac9568-682b-3e21-1d5b-ccca870910d5@westermo.com> (raw)
In-Reply-To: <20220803113041.GC29408@pc-4.home>
[-- Attachment #1.1: Type: text/plain, Size: 514 bytes --]
On 03/08/2022 13:30, Guillaume Nault wrote:
> On Tue, Aug 02, 2022 at 02:09:32PM +0200, Matthias May wrote:
>> According to Guillaume Nault RT_TOS should never be used for IPv6.
>>
>> Fixes: 3a56f86f1be6a ("geneve: handle ipv6 priority like ipv4 tos")
>
> While I'm at it, the SHA1 is normally truncated to 12 charaters, not 13.
>
Hi Guillaume
Ups, missed to remove the additional character in this patch.
For some reason git blame shows the SHA1 with 13 characters, not sure why.
BR
Matthias
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-08-03 12:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 12:09 [PATCH v2 net 0/4] Do not use RT_TOS for IPv6 flowlabel Matthias May
2022-08-02 12:09 ` [PATCH v2 net 1/4] geneve: do " Matthias May
2022-08-03 11:23 ` Guillaume Nault
2022-08-03 11:30 ` Guillaume Nault
2022-08-03 12:40 ` Matthias May [this message]
2022-08-03 15:30 ` David Ahern
2022-08-02 12:09 ` [PATCH v2 net 2/4] vxlan: " Matthias May
2022-08-03 15:31 ` David Ahern
2022-08-02 12:09 ` [PATCH v2 net 3/4] mlx5: " Matthias May
2022-08-02 12:09 ` [PATCH v2 net 4/4] ipv6: " Matthias May
2022-08-03 15:31 ` David Ahern
2022-08-03 11:27 ` [PATCH v2 net 0/4] Do " Guillaume Nault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19ac9568-682b-3e21-1d5b-ccca870910d5@westermo.com \
--to=matthias.may@westermo.com \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=cmi@nvidia.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eng.alaamohamedsoliman.am@gmail.com \
--cc=eyal.birger@gmail.com \
--cc=gnault@redhat.com \
--cc=hadarh@mellanox.com \
--cc=jesse@nicira.com \
--cc=kuba@kernel.org \
--cc=lariel@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=maord@nvidia.com \
--cc=martin.varghese@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=ogerlitz@mellanox.com \
--cc=pabeni@redhat.com \
--cc=roid@nvidia.com \
--cc=roopa@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=vladbu@nvidia.com \
--cc=willemb@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox