Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Matthias May <matthias.may@westermo.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <roopa@nvidia.com>,
	<eng.alaamohamedsoliman.am@gmail.com>, <bigeasy@linutronix.de>,
	<saeedm@nvidia.com>, <leon@kernel.org>, <roid@nvidia.com>,
	<maord@nvidia.com>, <lariel@nvidia.com>, <vladbu@nvidia.com>,
	<cmi@nvidia.com>, <gnault@redhat.com>, <yoshfuji@linux-ipv6.org>,
	<dsahern@kernel.org>, <linux-kernel@vger.kernel.org>,
	<bpf@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
	<nicolas.dichtel@6wind.com>, <eyal.birger@gmail.com>,
	<jesse@nicira.com>, <linville@tuxdriver.com>,
	<daniel@iogearbox.net>, <hadarh@mellanox.com>,
	<ogerlitz@mellanox.com>, <willemb@google.com>,
	<martin.varghese@nokia.com>,
	Matthias May <matthias.may@westermo.com>
Subject: [PATCH v2 net 4/4] ipv6: do not use RT_TOS for IPv6 flowlabel
Date: Tue, 2 Aug 2022 14:09:35 +0200	[thread overview]
Message-ID: <20220802120935.1363001-5-matthias.may@westermo.com> (raw)
In-Reply-To: <20220802120935.1363001-1-matthias.may@westermo.com>

According to Guillaume Nault RT_TOS should never be used for IPv6.

Fixes: 571912c69f0e ("net: UDP tunnel encapsulation module for tunnelling different protocols like MPLS, IP, NSH etc.")
Signed-off-by: Matthias May <matthias.may@westermo.com>
---
v1 -> v2:
 - Fix spacing of "Fixes" tag.
 - Add missing CCs
---
 net/ipv6/ip6_output.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
index 77e3f5970ce4..ec62f472aa1c 100644
--- a/net/ipv6/ip6_output.c
+++ b/net/ipv6/ip6_output.c
@@ -1311,8 +1311,7 @@ struct dst_entry *ip6_dst_lookup_tunnel(struct sk_buff *skb,
 	fl6.daddr = info->key.u.ipv6.dst;
 	fl6.saddr = info->key.u.ipv6.src;
 	prio = info->key.tos;
-	fl6.flowlabel = ip6_make_flowinfo(RT_TOS(prio),
-					  info->key.label);
+	fl6.flowlabel = ip6_make_flowinfo(prio, info->key.label);
 
 	dst = ipv6_stub->ipv6_dst_lookup_flow(net, sock->sk, &fl6,
 					      NULL);
-- 
2.35.1


  parent reply	other threads:[~2022-08-02 12:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-02 12:09 [PATCH v2 net 0/4] Do not use RT_TOS for IPv6 flowlabel Matthias May
2022-08-02 12:09 ` [PATCH v2 net 1/4] geneve: do " Matthias May
2022-08-03 11:23   ` Guillaume Nault
2022-08-03 11:30   ` Guillaume Nault
2022-08-03 12:40     ` Matthias May
2022-08-03 15:30   ` David Ahern
2022-08-02 12:09 ` [PATCH v2 net 2/4] vxlan: " Matthias May
2022-08-03 15:31   ` David Ahern
2022-08-02 12:09 ` [PATCH v2 net 3/4] mlx5: " Matthias May
2022-08-02 12:09 ` Matthias May [this message]
2022-08-03 15:31   ` [PATCH v2 net 4/4] ipv6: " David Ahern
2022-08-03 11:27 ` [PATCH v2 net 0/4] Do " Guillaume Nault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220802120935.1363001-5-matthias.may@westermo.com \
    --to=matthias.may@westermo.com \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=cmi@nvidia.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=eng.alaamohamedsoliman.am@gmail.com \
    --cc=eyal.birger@gmail.com \
    --cc=gnault@redhat.com \
    --cc=hadarh@mellanox.com \
    --cc=jesse@nicira.com \
    --cc=kuba@kernel.org \
    --cc=lariel@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=maord@nvidia.com \
    --cc=martin.varghese@nokia.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=ogerlitz@mellanox.com \
    --cc=pabeni@redhat.com \
    --cc=roid@nvidia.com \
    --cc=roopa@nvidia.com \
    --cc=saeedm@nvidia.com \
    --cc=vladbu@nvidia.com \
    --cc=willemb@google.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox