[PATCH 33/55] infiniband: irq: Remove IRQF_DISABLED

[PATCH 33/55] infiniband: irq: Remove IRQF_DISABLED

[Yong Zhang]

Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.

Signed-off-by: Yong Zhang <yong.zhang0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/hw/ehca/ehca_eq.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/ehca/ehca_eq.c b/drivers/infiniband/hw/ehca/ehca_eq.c
index d9b1bb4..818d721 100644
--- a/drivers/infiniband/hw/ehca/ehca_eq.c
+++ b/drivers/infiniband/hw/ehca/ehca_eq.c
@@ -125,7 +125,7 @@ int ehca_create_eq(struct ehca_shca *shca,
 		tasklet_init(&eq->interrupt_task, ehca_tasklet_eq, (long)shca);
 
 		ret = ibmebus_request_irq(eq->ist, ehca_interrupt_eq,
-					  IRQF_DISABLED, "ehca_eq",
+					  0, "ehca_eq",
 					  (void *)shca);
 		if (ret < 0)
 			ehca_err(ib_dev, "Can't map interrupt handler.");
@@ -133,7 +133,7 @@ int ehca_create_eq(struct ehca_shca *shca,
 		tasklet_init(&eq->interrupt_task, ehca_tasklet_neq, (long)shca);
 
 		ret = ibmebus_request_irq(eq->ist, ehca_interrupt_neq,
-					  IRQF_DISABLED, "ehca_neq",
+					  0, "ehca_neq",
 					  (void *)shca);
 		if (ret < 0)
 			ehca_err(ib_dev, "Can't map interrupt handler.");
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 33/55] infiniband: irq: Remove IRQF_DISABLED

[Roland Dreier]

Is someone taking this whole series, or should I take the ehca part?
(I know the ehca guys already acked this)

 - R.

Re: [PATCH 33/55] infiniband: irq: Remove IRQF_DISABLED

[Yong Zhang]

On Thu, Sep 22, 2011 at 09:56:07AM -0700, Roland Dreier wrote:
> Is someone taking this whole series, or should I take the ehca part?

You could take it and Thomas will take the leftovers.

> (I know the ehca guys already acked this)

Yeah, so I mentioned it in the cover letter :)

Thanks,
Yong

Re: [PATCH 33/55] infiniband: irq: Remove IRQF_DISABLED

[Yong Zhang]

On Fri, Sep 23, 2011 at 9:40 AM, Yong Zhang <yong.zhang0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On Thu, Sep 22, 2011 at 09:56:07AM -0700, Roland Dreier wrote:
>> Is someone taking this whole series, or should I take the ehca part?
>
> You could take it and Thomas will take the leftovers.
>
>> (I know the ehca guys already acked this)
>
> Yeah, so I mentioned it in the cover letter :)

Seems I still don't wake up yet. Sorry for my misreading.

So like I said above, you could take it if you want to.
Otherwise Thomas will take it.

Thanks,
Yong



-- 
Only stand for myself
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 33/55] infiniband: irq: Remove IRQF_DISABLED

[Roland Dreier]

On Thu, Sep 22, 2011 at 6:48 PM, Yong Zhang <yong.zhang0@gmail.com> wrote:
> So like I said above, you could take it if you want to.

Great, I queued this up for 3.2, thanks.