[PATCH 6/6] infiniband/nes: Disable ASPM

[PATCH 6/6] infiniband/nes: Disable ASPM

[Matthew Garrett]

The Windows driver .inf disables ASPM on hpsa devices. Do the same.

Signed-off-by: Matthew Garrett <mjg@redhat.com>
Cc: faisal.latif@intel.com
Cc: linux-rdma@vger.kernel.org
---
 drivers/infiniband/hw/nes/nes.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/hw/nes/nes.c b/drivers/infiniband/hw/nes/nes.c
index 5965b3d..2737b7a 100644
--- a/drivers/infiniband/hw/nes/nes.c
+++ b/drivers/infiniband/hw/nes/nes.c
@@ -463,6 +463,9 @@ static int __devinit nes_probe(struct pci_dev *pcidev, const struct pci_device_i
 	printk(KERN_INFO PFX "NetEffect RNIC driver v%s loading. (%s)\n",
 			DRV_VERSION, pci_name(pcidev));
 
+	pci_disable_link_state(pcidev, PCIE_LINK_STATE_L0S |
+			       PCIE_LINK_STATE_L1 | PCIE_LINK_STATE_CLKPM);
+
 	ret = pci_enable_device(pcidev);
 	if (ret) {
 		printk(KERN_ERR PFX "Unable to enable PCI device. (%s)\n", pci_name(pcidev));
-- 
1.7.7.1

Re: [PATCH 6/6] infiniband/nes: Disable ASPM

[Roland Dreier]

On Fri, Nov 11, 2011 at 8:05 AM, Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> The Windows driver .inf disables ASPM on hpsa devices. Do the same.

This isn't a patch to the hpsa driver... cut and paste in the description,
or misfire on the patch?

Faisal, any info on whether this is needed/desired for nes devices
based on Intel's knowledge of the PCIe core used?

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6] infiniband/nes: Disable ASPM

[Matthew Garrett]

On Fri, Nov 11, 2011 at 09:31:44AM -0800, Roland Dreier wrote:
> On Fri, Nov 11, 2011 at 8:05 AM, Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> > The Windows driver .inf disables ASPM on hpsa devices. Do the same.
> 
> This isn't a patch to the hpsa driver... cut and paste in the description,
> or misfire on the patch?

Sorry, yes, cut and paste in the description. It should say nes.

-- 
Matthew Garrett | mjg59-1xO5oi07KQx4cg9Nei1l7Q@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/6] infiniband/nes: Disable ASPM

[Roland Dreier]

> Sorry, yes, cut and paste in the description. It should say nes.

OK.  Just got a vacation message from Faisal that he's out til
next week, let's see if Intel has a comment on this.

Thanks,
  Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html