[PATCH] ib/cm: fix layout of APR message

[PATCH] ib/cm: fix layout of APR message

[Eli Cohen]

Add a missing 16 bit reserved field between ap_status and info fields.

Signed-off-by: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/infiniband/core/cm_msgs.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/infiniband/core/cm_msgs.h b/drivers/infiniband/core/cm_msgs.h
index 7e63c08..686ac1a 100644
--- a/drivers/infiniband/core/cm_msgs.h
+++ b/drivers/infiniband/core/cm_msgs.h
@@ -771,6 +771,7 @@ struct cm_apr_msg {
 
 	u8 info_length;
 	u8 ap_status;
+	u16 rsvd;
 	u8 info[IB_CM_APR_INFO_LENGTH];
 
 	u8 private_data[IB_CM_APR_PRIVATE_DATA_SIZE];
-- 
1.7.8

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] ib/cm: fix layout of APR message

[Hefty, Sean]

> Add a missing 16 bit reserved field between ap_status and info fields.
> 
> Signed-off-by: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---

Thanks for catching this.  Let's hope very few/no people are using APR in such a way that fixing this bug will bite them.

>  drivers/infiniband/core/cm_msgs.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/infiniband/core/cm_msgs.h
> b/drivers/infiniband/core/cm_msgs.h
> index 7e63c08..686ac1a 100644
> --- a/drivers/infiniband/core/cm_msgs.h
> +++ b/drivers/infiniband/core/cm_msgs.h
> @@ -771,6 +771,7 @@ struct cm_apr_msg {
> 
>  	u8 info_length;
>  	u8 ap_status;
> +	u16 rsvd;

For consistency with the rest of the file, please define this as __be16.

- Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ib/cm: fix layout of APR message

[Or Gerlitz]

On 12/19/2011 9:10 PM, Hefty, Sean wrote:
> Thanks for catching this. Let's hope very few/no people are using APR 
> in such a way that fixing this bug will bite them. 

no in-tree users so... I tend to agree there's no other choice here.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html