From: Jack Morgenstein <jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Or Gerlitz <or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Yevgeny Petrilin
<yevgenyp-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Subject: Re: [PATCH 3/3] mlx4_core: Disable SENSE_PORT for multifunction devices
Date: Tue, 2 Oct 2012 10:52:56 +0200 [thread overview]
Message-ID: <201210021052.57154.jackm@dev.mellanox.co.il> (raw)
In-Reply-To: <CAJZOPZLSBk0GEK-8SCAoXR0qCzpG9_P5nrWcWJ-vhcnKZAKvjg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thursday 27 September 2012 22:58, Or Gerlitz wrote:
> On Thu, Sep 27, 2012 at 7:47 PM, Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> > From: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
> >
> > In the current driver, the SENSE_PORT firmware command is issued as a
> > "wrapped" command, but the command handling code doesn't have a
> > wrapper, so it will never do anything other than log an error message.
> > The latest ConnectX-3 2.11.500 firmware reports the SENSE_PORT
> > capability even in multi-function (SR-IOV) mode, so the driver will
> > try to issue the command.
> >
> > At least until the driver has a proper wrapper for SENSE_PORT, make
> > sure we disable the command for multi-function devices.
>
> makes sense, nice doing!
>
> Acked-by: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> for patches 1-3
>
> Roland, I see that these three patches are queued @ your for-next and
> also the initial
> patch which in a way is more lengthy and heavy. I wonder whether
> wouldn't it be fare to allow for Jack to review it before pushing?
> Jack is back by Tuesday.
>
Acked-by: Jack Morgenstein <jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org> for patches 1-3
Nice going, Roland!
-Jack
> Or.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-10-02 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 17:47 [PATCH 1/3] mlx4_core: Stash PCI ID driver_data in mlx4_priv structure Roland Dreier
[not found] ` <1348768037-3660-1-git-send-email-roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-09-27 17:47 ` [PATCH 2/3] mlx4_core: Clean up enabling of SENSE_PORT for older (ConnectX-1/-2) HCAs Roland Dreier
2012-09-27 17:47 ` [PATCH 3/3] mlx4_core: Disable SENSE_PORT for multifunction devices Roland Dreier
[not found] ` <1348768037-3660-3-git-send-email-roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2012-09-27 20:58 ` Or Gerlitz
[not found] ` <CAJZOPZLSBk0GEK-8SCAoXR0qCzpG9_P5nrWcWJ-vhcnKZAKvjg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-02 8:52 ` Jack Morgenstein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201210021052.57154.jackm@dev.mellanox.co.il \
--to=jackm-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=or.gerlitz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=yevgenyp-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox