From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Garrett Cooper <yanegomi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] Avoid linker error with clang 3.0
Date: Sun, 9 Dec 2012 23:06:00 -0700 [thread overview]
Message-ID: <20121210060600.GA30472@obsidianresearch.com> (raw)
In-Reply-To: <ABB9B291-3AB5-4AE6-8CE2-5FE691E1AE02-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Sun, Dec 09, 2012 at 01:47:03PM -0800, Garrett Cooper wrote:
> After talking with some other more knowledgeable people than
> myself, it looks like opensm is depending upon gcc inline
> behavior:
> http://freebsd.1045724.n5.nabble.com/C99-inlines-td4157849.html
> , http://wiki.freebsd.org/PortsAndClang (look for "undefined
> or duplicate symbols while linking"). The previously attached
> patch should be ok for dealing with the linking problem as it
> just changes the scoping. Definitely learned a few things
> today about gcc :).
It is definately a bug in the code, it should be 'static inline' - the
reason it doesn't blow up on gcc is most likely because nobody ever
compiled it with a low enough optimization level to see it.
Looks to me like clang is fine, no bug there.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-12-10 6:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-09 11:07 [PATCH 3/3] Avoid linker error with clang 3.0 Garrett Cooper
[not found] ` <alpine.BSF.2.00.1212090306300.64779-Fqwm7F1mg36Nj9Bq2fkWzw@public.gmane.org>
2012-12-09 13:23 ` Bart Van Assche
[not found] ` <50C490D9.1000301-HInyCGIudOg@public.gmane.org>
2012-12-09 19:06 ` Garrett Cooper
[not found] ` <CAGH67wS1P43ssD+-VFyCupLw3CT8U73wT-aT6N2AS5ddWApAoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-09 19:28 ` Garrett Cooper
[not found] ` <CAGH67wQt48zEp0KiN44w=wfYZy+FA6oc=ehuAHUL2QBo=A1nhw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-09 21:47 ` Garrett Cooper
[not found] ` <ABB9B291-3AB5-4AE6-8CE2-5FE691E1AE02-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-10 6:06 ` Jason Gunthorpe [this message]
[not found] ` <20121210060600.GA30472-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-12-10 6:12 ` Garrett Cooper
[not found] ` <CAGH67wQ9ER9JLHR9ZKmzwMaGuV4m_5LdsHbKZvfYw1ekojik2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-11 10:08 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210060600.GA30472@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=bvanassche-HInyCGIudOg@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=yanegomi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox