Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Garrett Cooper <yanegomi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH 3/3] Avoid linker error with clang 3.0
Date: Sun, 9 Dec 2012 03:07:25 -0800 (PST)	[thread overview]
Message-ID: <alpine.BSF.2.00.1212090306300.64779@toaster.local> (raw)

[-- Attachment #1: Type: TEXT/PLAIN, Size: 707 bytes --]

It seems that there's a bug when linking inlined functions with clang; this
issue will need to be upstreamed and reverified with clang 3.2.

Signed-off-by: Garrett Cooper <yanegomi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
  osmtest/osmtest.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/osmtest/osmtest.c b/osmtest/osmtest.c
index 68b0e40..4f56106 100644
--- a/osmtest/osmtest.c
+++ b/osmtest/osmtest.c
@@ -3068,7 +3068,7 @@ Exit:
  	return (status);
  }

-inline uint32_t osmtest_path_rec_key_get(IN const ib_path_rec_t * const p_rec)
+static uint32_t osmtest_path_rec_key_get(IN const ib_path_rec_t * const p_rec)
  {
  	return (p_rec->dlid << 16 | p_rec->slid);
  }
-- 
1.8.0

[-- Attachment #2: Type: TEXT/PLAIN, Size: 907 bytes --]

From 998b75feaffe4066d4c19673190ec0b1fdfb03dc Mon Sep 17 00:00:00 2001
From: Garrett Cooper <yanegomi@gmail.com>
Date: Sun, 9 Dec 2012 02:57:43 -0800
Subject: [PATCH 3/3] Avoid linker error with clang 3.0

It seems that there's a bug when linking inlined functions with clang; this
issue will need to be upstreamed and reverified with clang 3.2.

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>
---
 osmtest/osmtest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/osmtest/osmtest.c b/osmtest/osmtest.c
index 68b0e40..4f56106 100644
--- a/osmtest/osmtest.c
+++ b/osmtest/osmtest.c
@@ -3068,7 +3068,7 @@ Exit:
 	return (status);
 }
 
-inline uint32_t osmtest_path_rec_key_get(IN const ib_path_rec_t * const p_rec)
+static uint32_t osmtest_path_rec_key_get(IN const ib_path_rec_t * const p_rec)
 {
 	return (p_rec->dlid << 16 | p_rec->slid);
 }
-- 
1.8.0


             reply	other threads:[~2012-12-09 11:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-09 11:07 Garrett Cooper [this message]
     [not found] ` <alpine.BSF.2.00.1212090306300.64779-Fqwm7F1mg36Nj9Bq2fkWzw@public.gmane.org>
2012-12-09 13:23   ` [PATCH 3/3] Avoid linker error with clang 3.0 Bart Van Assche
     [not found]     ` <50C490D9.1000301-HInyCGIudOg@public.gmane.org>
2012-12-09 19:06       ` Garrett Cooper
     [not found]         ` <CAGH67wS1P43ssD+-VFyCupLw3CT8U73wT-aT6N2AS5ddWApAoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-09 19:28           ` Garrett Cooper
     [not found]             ` <CAGH67wQt48zEp0KiN44w=wfYZy+FA6oc=ehuAHUL2QBo=A1nhw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-09 21:47               ` Garrett Cooper
     [not found]                 ` <ABB9B291-3AB5-4AE6-8CE2-5FE691E1AE02-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-12-10  6:06                   ` Jason Gunthorpe
     [not found]                     ` <20121210060600.GA30472-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2012-12-10  6:12                       ` Garrett Cooper
     [not found]                         ` <CAGH67wQ9ER9JLHR9ZKmzwMaGuV4m_5LdsHbKZvfYw1ekojik2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-11 10:08                           ` Garrett Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.BSF.2.00.1212090306300.64779@toaster.local \
    --to=yanegomi-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox