* [patch] RDMA/ocrdma: silence an integer underflow warning
@ 2013-09-06 8:50 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2013-09-06 8:50 UTC (permalink / raw)
To: Roland Dreier, Naresh Gottumukkala
Cc: Sean Hefty, Hal Rosenstock, Wei Yongjun, linux-rdma,
kernel-janitors
We recently added a cap on "max_wqe_allocated" in 43a6b4025c
('RDMA/ocrdma: Create IRD queue fix').
My static checker complains that the cap has a problem because it casts
large values to negative. "attrs->cap.max_send_wr" is a u32. It comes
from the user, but it's capped in ocrdma_check_qp_params() so it can't
wrap here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index 4ed8235..db39146 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1783,7 +1783,7 @@ static int ocrdma_set_create_qp_sq_cmd(struct ocrdma_create_qp_req *cmd,
u32 max_sges = attrs->cap.max_send_sge;
/* QP1 may exceed 127 */
- max_wqe_allocated = min_t(int, attrs->cap.max_send_wr + 1,
+ max_wqe_allocated = min_t(u32, attrs->cap.max_send_wr + 1,
dev->attr.max_wqe);
status = ocrdma_build_q_conf(&max_wqe_allocated,
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-09-06 8:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-06 8:50 [patch] RDMA/ocrdma: silence an integer underflow warning Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox