* [PATCH] mlx5: shift wrapping bug in mlx5_ib_get_buf_offset()
@ 2013-11-08 9:52 Dan Carpenter
2013-11-10 7:09 ` Eli Cohen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2013-11-08 9:52 UTC (permalink / raw)
To: Eli Cohen
Cc: Roland Dreier, Sean Hefty, Hal Rosenstock, linux-rdma,
kernel-janitors
"page_size" is declared as u64 but the (1 << page_shift) shift will wrap
at 32 bits.
Fixes: e126ba97dba9 ('mlx5: Add driver for Mellanox Connect-IB adapters')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/infiniband/hw/mlx5/mem.c b/drivers/infiniband/hw/mlx5/mem.c
index 3a53228..3020ec2 100644
--- a/drivers/infiniband/hw/mlx5/mem.c
+++ b/drivers/infiniband/hw/mlx5/mem.c
@@ -148,7 +148,7 @@ int mlx5_ib_get_buf_offset(u64 addr, int page_shift, u32 *offset)
u64 off_mask;
u64 buf_off;
- page_size = 1 << page_shift;
+ page_size = 1ULL << page_shift;
page_mask = page_size - 1;
buf_off = addr & page_mask;
off_size = page_size >> 6;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mlx5: shift wrapping bug in mlx5_ib_get_buf_offset()
2013-11-08 9:52 [PATCH] mlx5: shift wrapping bug in mlx5_ib_get_buf_offset() Dan Carpenter
@ 2013-11-10 7:09 ` Eli Cohen
0 siblings, 0 replies; 2+ messages in thread
From: Eli Cohen @ 2013-11-10 7:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: Eli Cohen, Roland Dreier, Sean Hefty, Hal Rosenstock, linux-rdma,
kernel-janitors
On Fri, Nov 08, 2013 at 12:52:59PM +0300, Dan Carpenter wrote:
> "page_size" is declared as u64 but the (1 << page_shift) shift will wrap
> at 32 bits.
I hope to live when this happnes :-)
I prefer to be explicit and use:
page_size = (u64)1 << page_shift;
>
> Fixes: e126ba97dba9 ('mlx5: Add driver for Mellanox Connect-IB adapters')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/infiniband/hw/mlx5/mem.c b/drivers/infiniband/hw/mlx5/mem.c
> index 3a53228..3020ec2 100644
> --- a/drivers/infiniband/hw/mlx5/mem.c
> +++ b/drivers/infiniband/hw/mlx5/mem.c
> @@ -148,7 +148,7 @@ int mlx5_ib_get_buf_offset(u64 addr, int page_shift, u32 *offset)
> u64 off_mask;
> u64 buf_off;
>
> - page_size = 1 << page_shift;
> + page_size = 1ULL << page_shift;
> page_mask = page_size - 1;
> buf_off = addr & page_mask;
> off_size = page_size >> 6;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-10 7:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-08 9:52 [PATCH] mlx5: shift wrapping bug in mlx5_ib_get_buf_offset() Dan Carpenter
2013-11-10 7:09 ` Eli Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox