From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Devesh Sharma <devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] rdma-core: define link speed and link width enums
Date: Mon, 8 May 2017 16:54:04 +0300 [thread overview]
Message-ID: <20170508135404.GD10073@mtr-leonro.local> (raw)
In-Reply-To: <1494251057-1060-1-git-send-email-devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 3038 bytes --]
On Mon, May 08, 2017 at 09:44:17AM -0400, Devesh Sharma wrote:
> Currently application either need to define its own enum
> values for link-speed and link-width or use hard coded
> values. This patch inharits the enums from kernel space
> ib_verbs.h and puts into verbs.h for ease of programming.
>
> Signed-off-by: Devesh Sharma <devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> ---
> libibverbs/examples/devinfo.c | 22 ++++++++++++----------
> libibverbs/verbs.h | 18 ++++++++++++++++++
> 2 files changed, 30 insertions(+), 10 deletions(-)
I think the better approach will be move these defines from
include/rdma/ib_verbs.h to include/uapi/rdma/ib_user_verbs.h
and reuse ib_user_verbs.h file directly in libibverbs.
>
> diff --git a/libibverbs/examples/devinfo.c b/libibverbs/examples/devinfo.c
> index 2c1e3f1..42ed50c 100644
> --- a/libibverbs/examples/devinfo.c
> +++ b/libibverbs/examples/devinfo.c
> @@ -124,10 +124,10 @@ static const char *mtu_str(enum ibv_mtu max_mtu)
> static const char *width_str(uint8_t width)
> {
> switch (width) {
> - case 1: return "1";
> - case 2: return "4";
> - case 4: return "8";
> - case 8: return "12";
> + case IBV_WIDTH_1X: return "1";
> + case IBV_WIDTH_4X: return "4";
> + case IBV_WIDTH_8X: return "8";
> + case IBV_WIDTH_12X: return "12";
> default: return "invalid width";
> }
> }
> @@ -135,14 +135,16 @@ static const char *width_str(uint8_t width)
> static const char *speed_str(uint8_t speed)
> {
> switch (speed) {
> - case 1: return "2.5 Gbps";
> - case 2: return "5.0 Gbps";
> + case IBV_SPEED_SDR: return "2.5 Gbps";
> + case IBV_SPEED_DDR: return "5.0 Gbps";
>
> - case 4: /* fall through */
> - case 8: return "10.0 Gbps";
> + case IBV_SPEED_QDR: /* fall through */
> + case IBV_SPEED_FDR10: return "10.0 Gbps";
>
> - case 16: return "14.0 Gbps";
> - case 32: return "25.0 Gbps";
> + case IBV_SPEED_FDR: return "14.0 Gbps";
> + case IBV_SPEED_EDR: return "25.0 Gbps";
> + case IBV_SPEED_HDR: return "50.0 Gbps";
> + case IBV_SPEE_NDR: return "100.0 Gbps";
> default: return "invalid speed";
> }
> }
> diff --git a/libibverbs/verbs.h b/libibverbs/verbs.h
> index b27dfd1..39a65fe 100644
> --- a/libibverbs/verbs.h
> +++ b/libibverbs/verbs.h
> @@ -290,6 +290,24 @@ enum ibv_port_state {
> IBV_PORT_ACTIVE_DEFER = 5
> };
>
> +enum ibv_port_speed {
> + IBV_SPEED_SDR = 1,
> + IBV_SPEED_DDR = 2,
> + IBV_SPEED_QDR = 4,
> + IBV_SPEED_FDR10 = 8,
> + IBV_SPEED_FDR = 16,
> + IBV_SPEED_EDR = 32,
> + IBV_SPEED_HDR = 64,
> + IBV_SPEED_NDR = 128
> +};
> +
> +enum ibv_port_width {
> + IBV_WIDTH_1X = 1,
> + IBV_WIDTH_4X = 2,
> + IBV_WIDTH_8X = 4,
> + IBV_WIDTH_12X = 8
> +};
> +
> enum {
> IBV_LINK_LAYER_UNSPECIFIED,
> IBV_LINK_LAYER_INFINIBAND,
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-05-08 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 13:44 [PATCH] rdma-core: define link speed and link width enums Devesh Sharma
[not found] ` <1494251057-1060-1-git-send-email-devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-05-08 13:54 ` Leon Romanovsky [this message]
[not found] ` <20170508135404.GD10073-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-08 14:05 ` Dennis Dalessandro
[not found] ` <e66a9fca-c6b3-ef6e-98b9-08d39bcc72d9-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-05-08 14:47 ` Devesh Sharma
[not found] ` <CANjDDBgeoiayNScofG=4CFUNbbqmizbvgtpWSHXcPqhatRSQoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-08 16:12 ` Jason Gunthorpe
[not found] ` <20170508161212.GA18125-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-08 17:00 ` Devesh Sharma
[not found] ` <CANjDDBjDwuL8dn4ACkeGw-bBge6_fhFN5DqSAK6h0SPBGeds+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-08 17:13 ` Jason Gunthorpe
2017-05-08 13:54 ` Hal Rosenstock
[not found] ` <de4b2ea7-9613-80c6-b4a1-288f5c5bedcd-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-05-08 14:39 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508135404.GD10073@mtr-leonro.local \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox