From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Devesh Sharma <devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: Dennis Dalessandro
<dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] rdma-core: define link speed and link width enums
Date: Mon, 8 May 2017 10:12:12 -0600 [thread overview]
Message-ID: <20170508161212.GA18125@obsidianresearch.com> (raw)
In-Reply-To: <CANjDDBgeoiayNScofG=4CFUNbbqmizbvgtpWSHXcPqhatRSQoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Mon, May 08, 2017 at 08:17:06PM +0530, Devesh Sharma wrote:
> On Mon, May 8, 2017 at 7:35 PM, Dennis Dalessandro
> <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> > On 05/08/2017 09:54 AM, Leon Romanovsky wrote:
> >>
> >> On Mon, May 08, 2017 at 09:44:17AM -0400, Devesh Sharma wrote:
> >>>
> >>> Currently application either need to define its own enum
> >>> values for link-speed and link-width or use hard coded
> >>> values. This patch inharits the enums from kernel space
> >>> ib_verbs.h and puts into verbs.h for ease of programming.
> >>>
> >>> Signed-off-by: Devesh Sharma <devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> >>> libibverbs/examples/devinfo.c | 22 ++++++++++++----------
> >>> libibverbs/verbs.h | 18 ++++++++++++++++++
> >>> 2 files changed, 30 insertions(+), 10 deletions(-)
> >>
> >>
> >> I think the better approach will be move these defines from
> >> include/rdma/ib_verbs.h to include/uapi/rdma/ib_user_verbs.h
> >> and reuse ib_user_verbs.h file directly in libibverbs.
> >
> >
> > I agree on this. Please put this stuff in the uapi header file and include
> > that in user space.
>
> Done, will post a V1 with 2 patches...
Relying on the kernel header from a uapi header means that we now
require the distro to have a sufficient version of that kernel header.
This might be OK, but you have to check to see what distros are
including (cbuild --run-shell can help with this)
Further, I seem to recall last time I lookd at this that using the
kernel header was hard because there were lots of name conflicts
that had to be resolved first. It would be great to see that done of
course..
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-05-08 16:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-08 13:44 [PATCH] rdma-core: define link speed and link width enums Devesh Sharma
[not found] ` <1494251057-1060-1-git-send-email-devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2017-05-08 13:54 ` Leon Romanovsky
[not found] ` <20170508135404.GD10073-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-05-08 14:05 ` Dennis Dalessandro
[not found] ` <e66a9fca-c6b3-ef6e-98b9-08d39bcc72d9-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-05-08 14:47 ` Devesh Sharma
[not found] ` <CANjDDBgeoiayNScofG=4CFUNbbqmizbvgtpWSHXcPqhatRSQoA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-08 16:12 ` Jason Gunthorpe [this message]
[not found] ` <20170508161212.GA18125-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2017-05-08 17:00 ` Devesh Sharma
[not found] ` <CANjDDBjDwuL8dn4ACkeGw-bBge6_fhFN5DqSAK6h0SPBGeds+Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-08 17:13 ` Jason Gunthorpe
2017-05-08 13:54 ` Hal Rosenstock
[not found] ` <de4b2ea7-9613-80c6-b4a1-288f5c5bedcd-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-05-08 14:39 ` Devesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170508161212.GA18125@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox