* Building rdma-core with -Wcast-qual
@ 2017-07-13 12:45 Sagi Grimberg
[not found] ` <ed258438-d585-d0ee-6c56-0178c589406b-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Sagi Grimberg @ 2017-07-13 12:45 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Hi all,
When I compile rdma-core with -Wcast-qual I get all sorts of warnings
on non following const on casts.
Does/should anyone care?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <ed258438-d585-d0ee-6c56-0178c589406b-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>]
* Re: Building rdma-core with -Wcast-qual [not found] ` <ed258438-d585-d0ee-6c56-0178c589406b-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> @ 2017-07-13 13:41 ` Leon Romanovsky 2017-07-13 22:29 ` Jason Gunthorpe 1 sibling, 0 replies; 3+ messages in thread From: Leon Romanovsky @ 2017-07-13 13:41 UTC (permalink / raw) To: Sagi Grimberg; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [-- Attachment #1: Type: text/plain, Size: 511 bytes --] On Thu, Jul 13, 2017 at 03:45:16PM +0300, Sagi Grimberg wrote: > Hi all, > > When I compile rdma-core with -Wcast-qual I get all sorts of warnings > on non following const on casts. > > Does/should anyone care? Yes, at least, everyone listed in MAINTAINERS file should care. Thanks > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Building rdma-core with -Wcast-qual [not found] ` <ed258438-d585-d0ee-6c56-0178c589406b-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> 2017-07-13 13:41 ` Leon Romanovsky @ 2017-07-13 22:29 ` Jason Gunthorpe 1 sibling, 0 replies; 3+ messages in thread From: Jason Gunthorpe @ 2017-07-13 22:29 UTC (permalink / raw) To: Sagi Grimberg; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On Thu, Jul 13, 2017 at 03:45:16PM +0300, Sagi Grimberg wrote: > Hi all, > > When I compile rdma-core with -Wcast-qual I get all sorts of warnings > on non following const on casts. > > Does/should anyone care? I looked at this once.. It gets really hard to do const correctness in C.. Eg, how do you handle this: #define container_of(ptr, type, member) \ ((type *) ((uint8_t *)(ptr) - offsetof(type, member))) if ptr is a const then it has to be: #define container_of(ptr, type, member) \ ((const type *) ((const uint8_t *)(ptr) - offsetof(type, member))) Similar issue for the ccan list macros. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-13 22:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-13 12:45 Building rdma-core with -Wcast-qual Sagi Grimberg
[not found] ` <ed258438-d585-d0ee-6c56-0178c589406b-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-07-13 13:41 ` Leon Romanovsky
2017-07-13 22:29 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox