Re: [PATCH v1] IB: Move PCI dependency from root KConfig to HW's KConfigs

[Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>]

On Tue, Sep 05, 2017 at 04:16:51AM +0000, Bart Van Assche wrote:
> On Tue, 2017-09-05 at 07:08 +0300, Leon Romanovsky wrote:
> > Why do we need to be dependent on CONFIG_BROKEN?
> > Is it still valid for IB stack?
> 
> Hello Leon,
> 
> As far as I know "&& BROKEN" makes sense but "|| BROKEN" not. The "|| BROKEN" 
> part was introduced through the following patch:

Can you elaborate more on (1) why BROKEN is needed and (2) why "&&" make
sense and "||" not?

> 
> 
> From a2b2f45be7e9138bde7fcba3b8e9257fea04d087 Mon Sep 17 00:00:00 2001
> From: Al Viro <viro-1walMZg8u8rXmaaqVzeoHQ@public.gmane.org>
> Date: Tue, 23 Aug 2005 22:45:41 +0100
> Subject: [PATCH] [PATCH] Kconfig fix (infiniband and PCI)
> 
> infiniband uses PCI helpers all over the place (including the core parts) and
> won't build without PCI.
> 
> Signed-off-by: Al Viro <viro-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
> Signed-off-by: Linus Torvalds <torvalds-3NddpPZAyC0@public.gmane.org>
> ---
>  drivers/infiniband/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> index 79c8e2dd9c33..32cdfb30e9b4 100644
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -1,6 +1,7 @@
>  menu "InfiniBand support"
>  
>  config INFINIBAND
> +	depends on PCI || BROKEN
>  	tristate "InfiniBand support"
>  	---help---
>  	  Core support for InfiniBand (IB).  Make sure to also select
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html