* [PATCH net-next] net/mlx5: fix an unused-function warning
@ 2018-07-17 13:49 Arnd Bergmann
2018-07-18 0:42 ` Saeed Mahameed
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2018-07-17 13:49 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, David S. Miller, Ilya Lesokhin,
Boris Pismenny
Cc: Arnd Bergmann, netdev, linux-rdma, linux-kernel
These dummy helpers are all intended to be inline functions,
but one of them by accident came without the 'inline' keyword,
causing a harmless warning:
In file included from drivers/net/ethernet/mellanox/mlx5/core/main.c:63:
drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h:79:1: error: 'mlx5_accel_tls_add_flow' defined but not used [-Werror=unused-function]
mlx5_accel_tls_add_flow(struct mlx5_core_dev *mdev, void *flow,
Fixes: ab412e1dd7db ("net/mlx5: Accel, add TLS rx offload routines")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h b/drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h
index 2228c1083528..def4093ebfae 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h
+++ b/drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h
@@ -75,7 +75,7 @@ void mlx5_accel_tls_cleanup(struct mlx5_core_dev *mdev);
#else
-static int
+static inline int
mlx5_accel_tls_add_flow(struct mlx5_core_dev *mdev, void *flow,
struct tls_crypto_info *crypto_info,
u32 start_offload_tcp_sn, u32 *p_swid,
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net/mlx5: fix an unused-function warning
2018-07-17 13:49 [PATCH net-next] net/mlx5: fix an unused-function warning Arnd Bergmann
@ 2018-07-18 0:42 ` Saeed Mahameed
2018-07-18 20:39 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Saeed Mahameed @ 2018-07-18 0:42 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Saeed Mahameed, Leon Romanovsky, David S. Miller, Ilya Lesokhin,
Boris Pismenny, Linux Netdev List, RDMA mailing list,
linux-kernel
On Tue, Jul 17, 2018 at 6:49 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> These dummy helpers are all intended to be inline functions,
> but one of them by accident came without the 'inline' keyword,
> causing a harmless warning:
>
> In file included from drivers/net/ethernet/mellanox/mlx5/core/main.c:63:
> drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h:79:1: error: 'mlx5_accel_tls_add_flow' defined but not used [-Werror=unused-function]
> mlx5_accel_tls_add_flow(struct mlx5_core_dev *mdev, void *flow,
>
> Fixes: ab412e1dd7db ("net/mlx5: Accel, add TLS rx offload routines")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Saeed Mahameed <saeedm@mellanox.com>
Dave, you can take this one to net-next.
Thanks!
> ---
> drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h b/drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h
> index 2228c1083528..def4093ebfae 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h
> @@ -75,7 +75,7 @@ void mlx5_accel_tls_cleanup(struct mlx5_core_dev *mdev);
>
> #else
>
> -static int
> +static inline int
> mlx5_accel_tls_add_flow(struct mlx5_core_dev *mdev, void *flow,
> struct tls_crypto_info *crypto_info,
> u32 start_offload_tcp_sn, u32 *p_swid,
> --
> 2.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net/mlx5: fix an unused-function warning
2018-07-18 0:42 ` Saeed Mahameed
@ 2018-07-18 20:39 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-07-18 20:39 UTC (permalink / raw)
To: saeedm; +Cc: arnd, saeedm, leon, ilyal, borisp, netdev, linux-rdma,
linux-kernel
From: Saeed Mahameed <saeedm@dev.mellanox.co.il>
Date: Tue, 17 Jul 2018 17:42:25 -0700
> On Tue, Jul 17, 2018 at 6:49 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>> These dummy helpers are all intended to be inline functions,
>> but one of them by accident came without the 'inline' keyword,
>> causing a harmless warning:
>>
>> In file included from drivers/net/ethernet/mellanox/mlx5/core/main.c:63:
>> drivers/net/ethernet/mellanox/mlx5/core/accel/tls.h:79:1: error: 'mlx5_accel_tls_add_flow' defined but not used [-Werror=unused-function]
>> mlx5_accel_tls_add_flow(struct mlx5_core_dev *mdev, void *flow,
>>
>> Fixes: ab412e1dd7db ("net/mlx5: Accel, add TLS rx offload routines")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Acked-by: Saeed Mahameed <saeedm@mellanox.com>
>
> Dave, you can take this one to net-next.
Sure, done.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-18 20:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-17 13:49 [PATCH net-next] net/mlx5: fix an unused-function warning Arnd Bergmann
2018-07-18 0:42 ` Saeed Mahameed
2018-07-18 20:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox