Re: [PATCH] siw: Fix potential NULL pointer in siw_connect().

[Leon Romanovsky <leon@kernel.org>]

On Wed, Aug 21, 2019 at 11:12:25AM -0300, Jason Gunthorpe wrote:
> On Wed, Aug 21, 2019 at 09:39:50AM -0400, Doug Ledford wrote:
> > On Wed, 2019-08-21 at 15:56 +0300, Dan Carpenter wrote:
> > > On Tue, Aug 20, 2019 at 12:05:33PM -0400, Doug Ledford wrote:
> > > > Please take a look (I pushed it out to my wip/dl-for-rc branch) so
> > > > you
> > > > can see what I mean about how to make both a simple subject line and
> > > > a
> > > > decent commit message.  Also, no final punctuation on the subject
> > > > line,
> > > > and try to keep the subject length <= 50 chars total.  If you have
> > > > to go
> > > > over to have a decent subject, then so be it, but we strive for that
> > > > 50
> > > > char limit to make a subject stay on one line when displayed using
> > > > git
> > > > log --oneline.
> > >
> > > 50 is really small.
> >
> > 50 is the vim syntax highlighting suggested limit.  You can go over,
> > which is why I indicated it was a soft limit, but there you are.  It
> > leaves room for the displayed hash length to grow as well.
>
> I use 75 for all text in the commit message, as per
> Documentation/process/submitting-patches.rst

checkpatch.pl will give warning if you have subject line above 75 chars.

>
> People using 'git log --oneline' should have terminals wider than 80
> :)

I like small terminals :(, it fits nicely with tiled WM on
my laptop screen.

>
> The bigger question is if the first character after the subject tag
> should be uppper case or lower case <hum>

It doesn't matter as long as person submitting patches is consistent.

Thanks

>
> Jason