From: Doug Ledford <dledford@redhat.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Dan Carpenter <dan.carpenter@oracle.com>
Cc: Bernard Metzler <bmt@zurich.ibm.com>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] siw: Fix potential NULL pointer in siw_connect().
Date: Thu, 22 Aug 2019 11:02:43 -0400 [thread overview]
Message-ID: <ccd7df7a3062c7db10480b411ee7bdcdbbb95cea.camel@redhat.com> (raw)
In-Reply-To: <20190822120211.GA8339@ziepe.ca>
[-- Attachment #1: Type: text/plain, Size: 933 bytes --]
On Thu, 2019-08-22 at 09:02 -0300, Jason Gunthorpe wrote:
> On Thu, Aug 22, 2019 at 10:10:23AM +0300, Dan Carpenter wrote:
>
> > > People using 'git log --oneline' should have terminals wider than
> > > 80
> > > :)
> > >
> > > The bigger question is if the first character after the subject
> > > tag
> > > should be uppper case or lower case <hum>
> >
> > I feel like more and more people are moving to upper case. There
> > are
> > some people who insist on upper case and no one who insists on lower
> > case so it's easier to just make everything upper case.
>
> I've noticed Andrew lower cases everything going through his
> tree. I've always used upper case for no prarticular reason
I prefer uppercase for the subsystem, and lowercase for the component.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-08-22 15:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 14:02 [PATCH] siw: Fix potential NULL pointer in siw_connect() Bernard Metzler
2019-08-20 16:05 ` Doug Ledford
2019-08-20 16:11 ` Bernard Metzler
2019-08-21 12:56 ` Dan Carpenter
2019-08-21 13:39 ` Doug Ledford
2019-08-21 14:12 ` Jason Gunthorpe
2019-08-21 16:30 ` Leon Romanovsky
2019-08-22 6:35 ` Gal Pressman
2019-08-22 7:10 ` Dan Carpenter
2019-08-22 12:02 ` Jason Gunthorpe
2019-08-22 15:02 ` Doug Ledford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccd7df7a3062c7db10480b411ee7bdcdbbb95cea.camel@redhat.com \
--to=dledford@redhat.com \
--cc=bmt@zurich.ibm.com \
--cc=dan.carpenter@oracle.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox