[PATCH v1] mlx4_core: fix wrong comment about the reason of subtract one from the max_cqes

[PATCH v1] mlx4_core: fix wrong comment about the reason of subtract one from the max_cqes

[Yuval Shaia]

From: Dotan Barak <dotanb@dev.mellanox.co.il>

The reason for the pre-allocation of one CQE is to enable resizing of
the CQ.
Fix comment accordingly.

Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>
Signed-off-by: Eli Cohen <eli@mellanox.co.il>
Signed-off-by: Vladimir Sokolovsky <vlad@mellanox.com>
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
---
v0 -> v1:
	* Add . at EOL
	* Add commit message
---
 drivers/net/ethernet/mellanox/mlx4/main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index fce9b3a24347..69bb6bb06e76 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -514,8 +514,7 @@ static int mlx4_dev_cap(struct mlx4_dev *dev, struct mlx4_dev_cap *dev_cap)
 	dev->caps.max_rq_desc_sz     = dev_cap->max_rq_desc_sz;
 	/*
 	 * Subtract 1 from the limit because we need to allocate a
-	 * spare CQE so the HCA HW can tell the difference between an
-	 * empty CQ and a full CQ.
+	 * spare CQE to enable resizing the CQ.
 	 */
 	dev->caps.max_cqes	     = dev_cap->max_cq_sz - 1;
 	dev->caps.reserved_cqs	     = dev_cap->reserved_cqs;
-- 
2.20.1

Re: [PATCH v1] mlx4_core: fix wrong comment about the reason of subtract one from the max_cqes

[Tariq Toukan]

On 11/3/2019 11:11 AM, Yuval Shaia wrote:
> From: Dotan Barak <dotanb@dev.mellanox.co.il>
> 
> The reason for the pre-allocation of one CQE is to enable resizing of
> the CQ.
> Fix comment accordingly.
> 
> Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>
> Signed-off-by: Eli Cohen <eli@mellanox.co.il>
> Signed-off-by: Vladimir Sokolovsky <vlad@mellanox.com>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
> ---
> v0 -> v1:
> 	* Add . at EOL
> 	* Add commit message
> ---
>   drivers/net/ethernet/mellanox/mlx4/main.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
> index fce9b3a24347..69bb6bb06e76 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/main.c
> @@ -514,8 +514,7 @@ static int mlx4_dev_cap(struct mlx4_dev *dev, struct mlx4_dev_cap *dev_cap)
>   	dev->caps.max_rq_desc_sz     = dev_cap->max_rq_desc_sz;
>   	/*
>   	 * Subtract 1 from the limit because we need to allocate a
> -	 * spare CQE so the HCA HW can tell the difference between an
> -	 * empty CQ and a full CQ.
> +	 * spare CQE to enable resizing the CQ.
>   	 */
>   	dev->caps.max_cqes	     = dev_cap->max_cq_sz - 1;
>   	dev->caps.reserved_cqs	     = dev_cap->reserved_cqs;
> 

Reviewed-by: Tariq Toukan <tariqt@mellanox.com>

Thanks.

Re: [PATCH v1] mlx4_core: fix wrong comment about the reason of subtract one from the max_cqes

[David Miller]

From: Yuval Shaia <yuval.shaia@oracle.com>
Date: Sun,  3 Nov 2019 11:11:35 +0200

> From: Dotan Barak <dotanb@dev.mellanox.co.il>
> 
> The reason for the pre-allocation of one CQE is to enable resizing of
> the CQ.
> Fix comment accordingly.
> 
> Signed-off-by: Dotan Barak <dotanb@dev.mellanox.co.il>
> Signed-off-by: Eli Cohen <eli@mellanox.co.il>
> Signed-off-by: Vladimir Sokolovsky <vlad@mellanox.com>
> Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>

Applied.