From: Jason Gunthorpe <jgg@mellanox.com>
To: Noa Osherovich <noaos@mellanox.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
Leon Romanovsky <leonro@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Edward Srouji <edwards@mellanox.com>,
Daria Velikovsky <daria@mellanox.com>
Subject: Re: [PATCH rdma-core 2/4] pyverbs: Introduce ParentDomain class
Date: Thu, 14 Nov 2019 13:39:58 +0000 [thread overview]
Message-ID: <20191114133954.GT21728@mellanox.com> (raw)
In-Reply-To: <20191114093732.12637-3-noaos@mellanox.com>
On Thu, Nov 14, 2019 at 09:37:46AM +0000, Noa Osherovich wrote:
> diff --git a/pyverbs/providers/mlx5/mlx5dv_enums.pxd b/pyverbs/providers/mlx5/mlx5dv_enums.pxd
> index 038a49111a3b..b02da9bf5001 100644
> +++ b/pyverbs/providers/mlx5/mlx5dv_enums.pxd
> @@ -45,3 +45,14 @@ cdef extern from 'infiniband/mlx5dv.h':
> MLX5DV_FLOW_ACTION_FLAGS_ESP_AES_GCM_SPI_STEERING = 1 << 2
> MLX5DV_FLOW_ACTION_FLAGS_ESP_AES_GCM_FULL_OFFLOAD = 1 << 3
> MLX5DV_FLOW_ACTION_FLAGS_ESP_AES_GCM_TX_IV_IS_ESN = 1 << 4
> +
> + cdef unsigned long long MLX5DV_RES_TYPE_QP
> + cdef unsigned long long MLX5DV_RES_TYPE_RWQ
> + cdef unsigned long long MLX5DV_RES_TYPE_DBR
> + cdef unsigned long long MLX5DV_RES_TYPE_SRQ
These are supposed to be enums, and should be cpdef
Jason
next prev parent reply other threads:[~2019-11-14 13:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 9:37 [PATCH rdma-core 0/4] pyverbs: Introduce parent domain Noa Osherovich
2019-11-14 9:37 ` [PATCH rdma-core 1/4] pyverbs: Add memory allocation class Noa Osherovich
2019-11-14 13:33 ` Jason Gunthorpe
2019-11-14 17:00 ` Edward Srouji
2019-11-14 17:04 ` Jason Gunthorpe
2019-11-14 9:37 ` [PATCH rdma-core 2/4] pyverbs: Introduce ParentDomain class Noa Osherovich
2019-11-14 13:39 ` Jason Gunthorpe [this message]
2019-11-14 16:49 ` Edward Srouji
2019-11-14 16:50 ` Jason Gunthorpe
[not found] ` <VI1PR05MB4157C8E9CA220454969633A6D74E0@VI1PR05MB4157.eurprd05.prod.outlook.com>
2019-11-21 16:31 ` Jason Gunthorpe
2019-11-14 9:37 ` [PATCH rdma-core 3/4] pyverbs: Document ParentDomain class and add a simple example Noa Osherovich
2019-11-14 9:37 ` [PATCH rdma-core 4/4] tests: Add a test for parent domain Noa Osherovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114133954.GT21728@mellanox.com \
--to=jgg@mellanox.com \
--cc=daria@mellanox.com \
--cc=dledford@redhat.com \
--cc=edwards@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=noaos@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox