From: Jason Gunthorpe <jgg@mellanox.com>
To: Edward Srouji <edwards@mellanox.com>
Cc: Noa Osherovich <noaos@mellanox.com>,
"dledford@redhat.com" <dledford@redhat.com>,
Leon Romanovsky <leonro@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Daria Velikovsky <daria@mellanox.com>
Subject: Re: [PATCH rdma-core 1/4] pyverbs: Add memory allocation class
Date: Thu, 14 Nov 2019 17:04:01 +0000 [thread overview]
Message-ID: <20191114170356.GW21728@mellanox.com> (raw)
In-Reply-To: <AM6PR05MB41529E366C190E52B0C58518D7710@AM6PR05MB4152.eurprd05.prod.outlook.com>
On Thu, Nov 14, 2019 at 05:00:00PM +0000, Edward Srouji wrote:
> I put the memory related functions under MemAlloc for multiple reasons:
> - The methods won't be confused with the C functions
> - The class is extensible with more memory related methods and functionality
>
> I think the other option would be defining them in another, separate, module (outside "base" module - which I less preferred)
It is an improper way to use a class
Jason
next prev parent reply other threads:[~2019-11-14 17:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 9:37 [PATCH rdma-core 0/4] pyverbs: Introduce parent domain Noa Osherovich
2019-11-14 9:37 ` [PATCH rdma-core 1/4] pyverbs: Add memory allocation class Noa Osherovich
2019-11-14 13:33 ` Jason Gunthorpe
2019-11-14 17:00 ` Edward Srouji
2019-11-14 17:04 ` Jason Gunthorpe [this message]
2019-11-14 9:37 ` [PATCH rdma-core 2/4] pyverbs: Introduce ParentDomain class Noa Osherovich
2019-11-14 13:39 ` Jason Gunthorpe
2019-11-14 16:49 ` Edward Srouji
2019-11-14 16:50 ` Jason Gunthorpe
[not found] ` <VI1PR05MB4157C8E9CA220454969633A6D74E0@VI1PR05MB4157.eurprd05.prod.outlook.com>
2019-11-21 16:31 ` Jason Gunthorpe
2019-11-14 9:37 ` [PATCH rdma-core 3/4] pyverbs: Document ParentDomain class and add a simple example Noa Osherovich
2019-11-14 9:37 ` [PATCH rdma-core 4/4] tests: Add a test for parent domain Noa Osherovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114170356.GW21728@mellanox.com \
--to=jgg@mellanox.com \
--cc=daria@mellanox.com \
--cc=dledford@redhat.com \
--cc=edwards@mellanox.com \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=noaos@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox