From: Jason Gunthorpe <jgg@ziepe.ca>
To: Selvin Xavier <selvin.xavier@broadcom.com>
Cc: Parav Pandit <parav@mellanox.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Devesh Sharma <devesh.sharma@broadcom.com>
Subject: Re: [PATCH for-next v2 1/2] IB/core: Add option to retrieve driver gid context from ib_gid_attr
Date: Thu, 19 Dec 2019 10:18:10 -0400 [thread overview]
Message-ID: <20191219141810.GA24224@ziepe.ca> (raw)
In-Reply-To: <CA+sbYW2nvT09ty8FsbG=GC_3MWJLJU8Mh_Lq+96ffvdxnfFr_Q@mail.gmail.com>
On Thu, Dec 19, 2019 at 10:36:45AM +0530, Selvin Xavier wrote:
> > Instead I guess a new symbol as rdma_get_gid_attr_context() can be added
> > too.
> I am okay with both adding context to gid_attr struct or adding a symbol.
> Let me know your preference.
> Or shall i handle this inside bnxt_re itself. Not sure whether any
> other drivers intend to use this.
Having a function to return the same void * that is passed to the
driver ops functions seems reasonable and small to me.
But you could also spruce this up a bit and have it work more like a
true 'priv' and get rid of that void *..
The container_of thing is really odd
Jason
next prev parent reply other threads:[~2019-12-19 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 6:19 [PATCH for-next v2 0/2] Retrieve HW GID context from ib_gid_attr Selvin Xavier
2019-12-16 6:20 ` [PATCH for-next v2 1/2] IB/core: Add option to retrieve driver gid " Selvin Xavier
2019-12-18 14:08 ` Jason Gunthorpe
2019-12-19 2:22 ` Parav Pandit
2019-12-19 5:06 ` Selvin Xavier
2019-12-19 14:18 ` Jason Gunthorpe [this message]
2020-02-18 6:16 ` Selvin Xavier
2019-12-16 6:20 ` [PATCH for-next v2 2/2] RDMA/bnxt_re: Retrieve the driver gid context from gid_attr Selvin Xavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219141810.GA24224@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox