From: Parav Pandit <parav@mellanox.com>
To: Jason Gunthorpe <jgg@ziepe.ca>,
Selvin Xavier <selvin.xavier@broadcom.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Devesh Sharma <devesh.sharma@broadcom.com>
Subject: Re: [PATCH for-next v2 1/2] IB/core: Add option to retrieve driver gid context from ib_gid_attr
Date: Thu, 19 Dec 2019 02:22:34 +0000 [thread overview]
Message-ID: <903a4154-8237-0178-dc5f-34c58fa06aaa@mellanox.com> (raw)
In-Reply-To: <20191218140835.GG17227@ziepe.ca>
On 12/18/2019 7:38 PM, Jason Gunthorpe wrote:
> On Sun, Dec 15, 2019 at 10:20:00PM -0800, Selvin Xavier wrote:
>> Provide an option to retrieve the driver gid context from ib_gid_attr
>> structure. Introduce ib_gid_attr_info structure which include both
>> gid_attr and the GID's HW context. Replace the attr and context
>> members of ib_gid_table_entry with the new ib_gid_attr_info
>> structure. Vendor drivers can refer to its own HW gid context
>> using the container_of macro.
>
> This seems really weird. Why are we adding a new struct instead of
> adding context to the normal gid_attr, or adding some
> 'get_ib_attr_priv' call?
Rest of the stack didn't need to touch context, so it is added only as
vendor driver facing container_of().
Instead I guess a new symbol as rdma_get_gid_attr_context() can be added
too.
next prev parent reply other threads:[~2019-12-19 2:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 6:19 [PATCH for-next v2 0/2] Retrieve HW GID context from ib_gid_attr Selvin Xavier
2019-12-16 6:20 ` [PATCH for-next v2 1/2] IB/core: Add option to retrieve driver gid " Selvin Xavier
2019-12-18 14:08 ` Jason Gunthorpe
2019-12-19 2:22 ` Parav Pandit [this message]
2019-12-19 5:06 ` Selvin Xavier
2019-12-19 14:18 ` Jason Gunthorpe
2020-02-18 6:16 ` Selvin Xavier
2019-12-16 6:20 ` [PATCH for-next v2 2/2] RDMA/bnxt_re: Retrieve the driver gid context from gid_attr Selvin Xavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=903a4154-8237-0178-dc5f-34c58fa06aaa@mellanox.com \
--to=parav@mellanox.com \
--cc=devesh.sharma@broadcom.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox