From: Christoph Hellwig <hch@infradead.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Jason Gunthorpe <jgg@mellanox.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH v9 0/3] Proposed trace points for RDMA/core
Date: Tue, 7 Jan 2020 05:47:28 -0800 [thread overview]
Message-ID: <20200107134728.GA375@infradead.org> (raw)
In-Reply-To: <FFC65516-E488-472C-90EA-DBE54BE341C8@oracle.com>
On Wed, Dec 18, 2019 at 08:20:20AM -0500, Chuck Lever wrote:
>
>
> > On Dec 18, 2019, at 12:36 AM, Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Wed, Dec 18, 2019 at 12:22:19AM +0000, Jason Gunthorpe wrote:
> >> On Mon, Dec 16, 2019 at 10:53:43AM -0500, Chuck Lever wrote:
> >>> Hey y'all-
> >>>
> >>> Refresh of the RDMA/core trace point patches. Anything else needed
> >>> before these are acceptable?
> >>
> >> Can Leon compile and run it yet?
> >
> > Nope, it is enough to apply first patch to see compilation error.
>
> I've never seen that here. There is another report of this problem
> with an earlier version of the series, so I thought it had been
> resolved.
>
> I'll look into it.
You tend to need a line like:
ccflags-y += -I $(srctree)/$(src) # needed for trace events
to ensure the trace header actually gets included for out of source
tree builds. Or move the trace header to include/trave/events/. I find
that annoying for simple modules, but for a subsystem where the trace
header might be spread over various directories that might end up being
much easier.
next prev parent reply other threads:[~2020-01-07 13:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 15:53 [PATCH v9 0/3] Proposed trace points for RDMA/core Chuck Lever
2019-12-16 15:53 ` [PATCH v9 1/3] RDMA/cma: Add trace points in RDMA Connection Manager Chuck Lever
2019-12-16 15:53 ` [PATCH v9 2/3] RDMA/core: Trace points for diagnosing completion queue issues Chuck Lever
2019-12-16 15:53 ` [PATCH v9 3/3] RDMA/core: Add trace points to follow MR allocation Chuck Lever
2019-12-18 0:22 ` [PATCH v9 0/3] Proposed trace points for RDMA/core Jason Gunthorpe
2019-12-18 5:36 ` Leon Romanovsky
2019-12-18 13:20 ` Chuck Lever
2020-01-07 13:47 ` Christoph Hellwig [this message]
2020-01-07 14:39 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107134728.GA375@infradead.org \
--to=hch@infradead.org \
--cc=chuck.lever@oracle.com \
--cc=dledford@redhat.com \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox