From: Jason Gunthorpe <jgg@ziepe.ca>
To: Devesh Sharma <devesh.sharma@broadcom.com>
Cc: linux-rdma@vger.kernel.org, leon@kernel.org
Subject: Re: [PATCH v4] libibverbs: display gid type in ibv_devinfo
Date: Mon, 3 Feb 2020 12:08:49 -0400 [thread overview]
Message-ID: <20200203160849.GA14732@ziepe.ca> (raw)
In-Reply-To: <1580745415-19744-1-git-send-email-devesh.sharma@broadcom.com>
On Mon, Feb 03, 2020 at 10:56:55AM -0500, Devesh Sharma wrote:
> It becomes difficult to make out from the output of ibv_devinfo
> if a particular gid index is RoCE v2 or not.
>
> Adding a string to the output of ibv_devinfo -v to display the
> gid type at the end of gid.
>
> The output would look something like below:
> $ ibv_devinfo -v -d bnxt_re2
> hca_id: bnxt_re2
> transport: InfiniBand (0)
> fw_ver: 216.0.220.0
> node_guid: b226:28ff:fed3:b0f0
> sys_image_guid: b226:28ff:fed3:b0f0
> .
> .
> .
> .
> phys_state: LINK_UP (5)
> GID[ 0]: fe80:0000:0000:0000:b226:28ff:fed3:b0f0, IB/RoCE v1
> GID[ 1]: fe80:0000:0000:0000:b226:28ff:fed3:b0f0, RoCE v2
> GID[ 2]: 0000:0000:0000:0000:0000:ffff:c0aa:0165, IB/RoCE v1
> GID[ 3]: 0000:0000:0000:0000:0000:ffff:c0aa:0165, RoCE v2
I think you should display the RoCEv2 GID in IPv6 notation, since it
isn't really a GID anyhmore. The IPv6 notation should automatically
show the IPv4 dotted quad
Jason
next prev parent reply other threads:[~2020-02-03 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 15:56 [PATCH v4] libibverbs: display gid type in ibv_devinfo Devesh Sharma
2020-02-03 16:08 ` Jason Gunthorpe [this message]
2020-02-03 16:27 ` Devesh Sharma
2020-02-03 16:50 ` Jason Gunthorpe
2020-02-03 17:52 ` Devesh Sharma
2020-02-03 18:18 ` Gal Pressman
2020-02-03 18:23 ` Devesh Sharma
2020-02-03 19:44 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203160849.GA14732@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=devesh.sharma@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox