From: Gal Pressman <galpress@amazon.com>
To: Devesh Sharma <devesh.sharma@broadcom.com>
Cc: <linux-rdma@vger.kernel.org>, <jgg@mellanox.com>, <leon@kernel.org>
Subject: Re: [PATCH v4] libibverbs: display gid type in ibv_devinfo
Date: Mon, 3 Feb 2020 20:18:23 +0200 [thread overview]
Message-ID: <b9fc34ae-6da8-0d12-e069-cdbf9dc06e25@amazon.com> (raw)
In-Reply-To: <1580745415-19744-1-git-send-email-devesh.sharma@broadcom.com>
On 03/02/2020 17:56, Devesh Sharma wrote:
> diff --git a/libibverbs/driver.h b/libibverbs/driver.h
> index a0e6f89..fc0699d 100644
> --- a/libibverbs/driver.h
> +++ b/libibverbs/driver.h
> @@ -84,6 +84,7 @@ enum verbs_qp_mask {
> enum ibv_gid_type {
> IBV_GID_TYPE_IB_ROCE_V1,
> IBV_GID_TYPE_ROCE_V2,
> + IBV_GID_TYPE_INVALID
> };
I don't think that's right.
You're adding a new enum value to libibverbs, but it's not really
used/implemented there.
If devinfo needs an invalid GID value, make it local to that program.
next prev parent reply other threads:[~2020-02-03 18:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 15:56 [PATCH v4] libibverbs: display gid type in ibv_devinfo Devesh Sharma
2020-02-03 16:08 ` Jason Gunthorpe
2020-02-03 16:27 ` Devesh Sharma
2020-02-03 16:50 ` Jason Gunthorpe
2020-02-03 17:52 ` Devesh Sharma
2020-02-03 18:18 ` Gal Pressman [this message]
2020-02-03 18:23 ` Devesh Sharma
2020-02-03 19:44 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9fc34ae-6da8-0d12-e069-cdbf9dc06e25@amazon.com \
--to=galpress@amazon.com \
--cc=devesh.sharma@broadcom.com \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox