* [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; [not found] <cover.1583896344.git.joe@perches.com> @ 2020-03-11 4:51 ` Joe Perches 2020-03-11 7:01 ` Leon Romanovsky 2020-03-12 6:23 ` David Miller 2020-03-11 4:51 ` [PATCH -next 003/491] MELLANOX MLX5 core VPI driver: " Joe Perches 1 sibling, 2 replies; 9+ messages in thread From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw) To: Boris Pismenny Cc: Saeed Mahameed, Leon Romanovsky, David S. Miller, netdev, linux-rdma, linux-kernel Convert the various uses of fallthrough comments to fallthrough; Done via script Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c index f260dd..42978f8 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c @@ -466,7 +466,7 @@ struct sk_buff *mlx5e_ktls_handle_tx_skb(struct net_device *netdev, if (likely(!skb->decrypted)) goto out; WARN_ON_ONCE(1); - /* fall-through */ + fallthrough; default: /* MLX5E_KTLS_SYNC_FAIL */ goto err_out; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c b/drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c index 6102113..d35bbc 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c @@ -339,14 +339,14 @@ static void mlx5_fpga_conn_handle_cqe(struct mlx5_fpga_conn *conn, switch (opcode) { case MLX5_CQE_REQ_ERR: status = ((struct mlx5_err_cqe *)cqe)->syndrome; - /* Fall through */ + fallthrough; case MLX5_CQE_REQ: mlx5_fpga_conn_sq_cqe(conn, cqe, status); break; case MLX5_CQE_RESP_ERR: status = ((struct mlx5_err_cqe *)cqe)->syndrome; - /* Fall through */ + fallthrough; case MLX5_CQE_RESP_SEND: mlx5_fpga_conn_rq_cqe(conn, cqe, status); break; -- 2.24.0 ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; 2020-03-11 4:51 ` [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; Joe Perches @ 2020-03-11 7:01 ` Leon Romanovsky 2020-03-12 6:23 ` David Miller 1 sibling, 0 replies; 9+ messages in thread From: Leon Romanovsky @ 2020-03-11 7:01 UTC (permalink / raw) To: Joe Perches Cc: Boris Pismenny, Saeed Mahameed, David S. Miller, netdev, linux-rdma, linux-kernel On Tue, Mar 10, 2020 at 09:51:15PM -0700, Joe Perches wrote: > Convert the various uses of fallthrough comments to fallthrough; > > Done via script > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky <leonro@mellanox.com> ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; 2020-03-11 4:51 ` [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; Joe Perches 2020-03-11 7:01 ` Leon Romanovsky @ 2020-03-12 6:23 ` David Miller 2020-03-12 6:26 ` Joe Perches 1 sibling, 1 reply; 9+ messages in thread From: David Miller @ 2020-03-12 6:23 UTC (permalink / raw) To: joe; +Cc: borisp, saeedm, leon, netdev, linux-rdma, linux-kernel Joe, please use Subject line subsystem prefixes consistent with what would be used for other changes to these drivers. Thank you. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; 2020-03-12 6:23 ` David Miller @ 2020-03-12 6:26 ` Joe Perches 2020-03-12 8:03 ` David Miller 2020-03-12 19:45 ` Jakub Kicinski 0 siblings, 2 replies; 9+ messages in thread From: Joe Perches @ 2020-03-12 6:26 UTC (permalink / raw) To: David Miller; +Cc: borisp, saeedm, leon, netdev, linux-rdma, linux-kernel On Wed, 2020-03-11 at 23:23 -0700, David Miller wrote: > Joe, please use Subject line subsystem prefixes consistent with what would > be used for other changes to these drivers. Not easy to do for scripted patches. There's no mechanism that scriptable. I'm not going to hand-edit 500 patches. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; 2020-03-12 6:26 ` Joe Perches @ 2020-03-12 8:03 ` David Miller 2020-03-12 19:45 ` Jakub Kicinski 1 sibling, 0 replies; 9+ messages in thread From: David Miller @ 2020-03-12 8:03 UTC (permalink / raw) To: joe; +Cc: borisp, saeedm, leon, netdev, linux-rdma, linux-kernel From: Joe Perches <joe@perches.com> Date: Wed, 11 Mar 2020 23:26:59 -0700 > I'm not going to hand-edit 500 patches. Then I'm not applying your stuff, it's as simple as that. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; 2020-03-12 6:26 ` Joe Perches 2020-03-12 8:03 ` David Miller @ 2020-03-12 19:45 ` Jakub Kicinski 2020-03-12 19:52 ` Joe Perches 1 sibling, 1 reply; 9+ messages in thread From: Jakub Kicinski @ 2020-03-12 19:45 UTC (permalink / raw) To: Joe Perches Cc: David Miller, borisp, saeedm, leon, netdev, linux-rdma, linux-kernel On Wed, 11 Mar 2020 23:26:59 -0700 Joe Perches wrote: > On Wed, 2020-03-11 at 23:23 -0700, David Miller wrote: > > Joe, please use Subject line subsystem prefixes consistent with what would > > be used for other changes to these drivers. > > Not easy to do for scripted patches. > There's no mechanism that scriptable. I have this to show me the top 3 prefixes used for files currently modified in my tree: tgs() { local fs fs=$(git status -s | sed -n 's/ M //p') git log --oneline --no-merges -- $fs | \ sed -e's/[^ ]* \(.*\):[^:]*/\1/' | \ sort | uniq -c | sort -rn | head -3 } You could probably massage it to just give you to top one and feed that into git commit template? ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; 2020-03-12 19:45 ` Jakub Kicinski @ 2020-03-12 19:52 ` Joe Perches 0 siblings, 0 replies; 9+ messages in thread From: Joe Perches @ 2020-03-12 19:52 UTC (permalink / raw) To: Jakub Kicinski Cc: David Miller, borisp, saeedm, leon, netdev, linux-rdma, linux-kernel On Thu, 2020-03-12 at 12:45 -0700, Jakub Kicinski wrote: > On Wed, 11 Mar 2020 23:26:59 -0700 Joe Perches wrote: > > On Wed, 2020-03-11 at 23:23 -0700, David Miller wrote: > > > Joe, please use Subject line subsystem prefixes consistent with what would > > > be used for other changes to these drivers. > > > > Not easy to do for scripted patches. > > There's no mechanism that scriptable. > > I have this to show me the top 3 prefixes used for files currently > modified in my tree: > > tgs() { > local fs > > fs=$(git status -s | sed -n 's/ M //p') > > git log --oneline --no-merges -- $fs | \ > sed -e's/[^ ]* \(.*\):[^:]*/\1/' | \ > sort | uniq -c | sort -rn | head -3 > } > > You could probably massage it to just give you to top one and feed > that into git commit template? I had already tried that via: $ cat get_patch_subject_prefix.bash #!/bin/bash git log --format="%s" --no-merges -200 --since=2-years-ago $@ | \ cut -f1 -d":" | \ sort | uniq -c | sort -rn | head -1 | \ sed 's/^[[:space:]]*[[:digit:]]*[[:space:]]*//' $ It doesn't work very well for many of the subsystems. For instance, this script produces things like: ARM/ZYNQ ARCHITECTURE: treewide FCOE SUBSYSTEM (libfc, libfcoe, fcoe): scsi WOLFSON MICROELECTRONICS DRIVERS: ASoC There isn't a great single mechanism for this. At various times, I have proposed adding a grammar for patch subject titles to MAINTAINERS. Like: https://lore.kernel.org/lkml/1289919077.28741.50.camel@Joe-Laptop/ ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH -next 003/491] MELLANOX MLX5 core VPI driver: Use fallthrough; [not found] <cover.1583896344.git.joe@perches.com> 2020-03-11 4:51 ` [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; Joe Perches @ 2020-03-11 4:51 ` Joe Perches 2020-03-11 7:00 ` Leon Romanovsky 1 sibling, 1 reply; 9+ messages in thread From: Joe Perches @ 2020-03-11 4:51 UTC (permalink / raw) To: Alexei Starovoitov, Daniel Borkmann, David S. Miller, Jakub Kicinski, Jesper Dangaard Brouer, John Fastabend, Saeed Mahameed, Leon Romanovsky Cc: netdev, linux-rdma, linux-kernel, bpf Convert the various uses of fallthrough comments to fallthrough; Done via script Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 ++-- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 2 +- .../net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c | 8 ++++---- drivers/net/ethernet/mellanox/mlx5/core/vport.c | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h b/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h index a226277..2a1cc2 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h @@ -223,7 +223,7 @@ mlx5e_set_eseg_swp(struct sk_buff *skb, struct mlx5_wqe_eth_seg *eseg, switch (swp_spec->tun_l4_proto) { case IPPROTO_UDP: eseg->swp_flags |= MLX5_ETH_WQE_SWP_INNER_L4_UDP; - /* fall through */ + fallthrough; case IPPROTO_TCP: eseg->swp_inner_l4_offset = skb_inner_transport_offset(skb) / 2; break; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c index f049e0a..f74e50 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c @@ -167,11 +167,11 @@ bool mlx5e_xdp_handle(struct mlx5e_rq *rq, struct mlx5e_dma_info *di, return true; default: bpf_warn_invalid_xdp_action(act); - /* fall through */ + fallthrough; case XDP_ABORTED: xdp_abort: trace_xdp_exception(rq->netdev, prog, act); - /* fall through */ + fallthrough; case XDP_DROP: rq->stats->xdp_drop++; return true; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c index 01539b8..8a3376a 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c @@ -225,7 +225,7 @@ int mlx5e_ethtool_get_sset_count(struct mlx5e_priv *priv, int sset) return MLX5E_NUM_PFLAGS; case ETH_SS_TEST: return mlx5e_self_test_num(priv); - /* fallthrough */ + fallthrough; default: return -EOPNOTSUPP; } diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c index 4b5b661..033454 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c @@ -2426,7 +2426,7 @@ int mlx5_devlink_eswitch_inline_mode_set(struct devlink *devlink, u8 mode, case MLX5_CAP_INLINE_MODE_NOT_REQUIRED: if (mode == DEVLINK_ESWITCH_INLINE_MODE_NONE) return 0; - /* fall through */ + fallthrough; case MLX5_CAP_INLINE_MODE_L2: NL_SET_ERR_MSG_MOD(extack, "Inline mode can't be set"); return -EOPNOTSUPP; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c index 416676..a40e43 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c @@ -199,13 +199,13 @@ static void mlx5_lag_fib_update(struct work_struct *work) /* Protect internal structures from changes */ rtnl_lock(); switch (fib_work->event) { - case FIB_EVENT_ENTRY_REPLACE: /* fall through */ + case FIB_EVENT_ENTRY_REPLACE: case FIB_EVENT_ENTRY_DEL: mlx5_lag_fib_route_event(ldev, fib_work->event, fib_work->fen_info.fi); fib_info_put(fib_work->fen_info.fi); break; - case FIB_EVENT_NH_ADD: /* fall through */ + case FIB_EVENT_NH_ADD: case FIB_EVENT_NH_DEL: fib_nh = fib_work->fnh_info.fib_nh; mlx5_lag_fib_nexthop_event(ldev, @@ -256,7 +256,7 @@ static int mlx5_lag_fib_event(struct notifier_block *nb, return NOTIFY_DONE; switch (event) { - case FIB_EVENT_ENTRY_REPLACE: /* fall through */ + case FIB_EVENT_ENTRY_REPLACE: case FIB_EVENT_ENTRY_DEL: fen_info = container_of(info, struct fib_entry_notifier_info, info); @@ -279,7 +279,7 @@ static int mlx5_lag_fib_event(struct notifier_block *nb, */ fib_info_hold(fib_work->fen_info.fi); break; - case FIB_EVENT_NH_ADD: /* fall through */ + case FIB_EVENT_NH_ADD: case FIB_EVENT_NH_DEL: fnh_info = container_of(info, struct fib_nh_notifier_info, info); diff --git a/drivers/net/ethernet/mellanox/mlx5/core/vport.c b/drivers/net/ethernet/mellanox/mlx5/core/vport.c index 1faac31f..aea1065 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/vport.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/vport.c @@ -125,7 +125,7 @@ void mlx5_query_min_inline(struct mlx5_core_dev *mdev, case MLX5_CAP_INLINE_MODE_VPORT_CONTEXT: if (!mlx5_query_nic_vport_min_inline(mdev, 0, min_inline_mode)) break; - /* fall through */ + fallthrough; case MLX5_CAP_INLINE_MODE_L2: *min_inline_mode = MLX5_INLINE_MODE_L2; break; -- 2.24.0 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH -next 003/491] MELLANOX MLX5 core VPI driver: Use fallthrough; 2020-03-11 4:51 ` [PATCH -next 003/491] MELLANOX MLX5 core VPI driver: " Joe Perches @ 2020-03-11 7:00 ` Leon Romanovsky 0 siblings, 0 replies; 9+ messages in thread From: Leon Romanovsky @ 2020-03-11 7:00 UTC (permalink / raw) To: Joe Perches Cc: Alexei Starovoitov, Daniel Borkmann, David S. Miller, Jakub Kicinski, Jesper Dangaard Brouer, John Fastabend, Saeed Mahameed, netdev, linux-rdma, linux-kernel, bpf On Tue, Mar 10, 2020 at 09:51:17PM -0700, Joe Perches wrote: > Convert the various uses of fallthrough comments to fallthrough; > > Done via script > Link: https://lore.kernel.org/lkml/b56602fcf79f849e733e7b521bb0e17895d390fa.1582230379.git.joe.com/ > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 ++-- > drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 2 +- > .../net/ethernet/mellanox/mlx5/core/eswitch_offloads.c | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c | 8 ++++---- > drivers/net/ethernet/mellanox/mlx5/core/vport.c | 2 +- > 6 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h b/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h > index a226277..2a1cc2 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h > @@ -223,7 +223,7 @@ mlx5e_set_eseg_swp(struct sk_buff *skb, struct mlx5_wqe_eth_seg *eseg, > switch (swp_spec->tun_l4_proto) { > case IPPROTO_UDP: > eseg->swp_flags |= MLX5_ETH_WQE_SWP_INNER_L4_UDP; > - /* fall through */ > + fallthrough; > case IPPROTO_TCP: > eseg->swp_inner_l4_offset = skb_inner_transport_offset(skb) / 2; > break; > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c > index f049e0a..f74e50 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c > @@ -167,11 +167,11 @@ bool mlx5e_xdp_handle(struct mlx5e_rq *rq, struct mlx5e_dma_info *di, > return true; > default: > bpf_warn_invalid_xdp_action(act); > - /* fall through */ > + fallthrough; > case XDP_ABORTED: > xdp_abort: > trace_xdp_exception(rq->netdev, prog, act); > - /* fall through */ > + fallthrough; > case XDP_DROP: > rq->stats->xdp_drop++; > return true; > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > index 01539b8..8a3376a 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c > @@ -225,7 +225,7 @@ int mlx5e_ethtool_get_sset_count(struct mlx5e_priv *priv, int sset) > return MLX5E_NUM_PFLAGS; > case ETH_SS_TEST: > return mlx5e_self_test_num(priv); > - /* fallthrough */ > + fallthrough; This should be removed, there is return before. > default: > return -EOPNOTSUPP; > } > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c > index 4b5b661..033454 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c > @@ -2426,7 +2426,7 @@ int mlx5_devlink_eswitch_inline_mode_set(struct devlink *devlink, u8 mode, > case MLX5_CAP_INLINE_MODE_NOT_REQUIRED: > if (mode == DEVLINK_ESWITCH_INLINE_MODE_NONE) > return 0; > - /* fall through */ > + fallthrough; > case MLX5_CAP_INLINE_MODE_L2: > NL_SET_ERR_MSG_MOD(extack, "Inline mode can't be set"); > return -EOPNOTSUPP; > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c > index 416676..a40e43 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag_mp.c > @@ -199,13 +199,13 @@ static void mlx5_lag_fib_update(struct work_struct *work) > /* Protect internal structures from changes */ > rtnl_lock(); > switch (fib_work->event) { > - case FIB_EVENT_ENTRY_REPLACE: /* fall through */ > + case FIB_EVENT_ENTRY_REPLACE: > case FIB_EVENT_ENTRY_DEL: > mlx5_lag_fib_route_event(ldev, fib_work->event, > fib_work->fen_info.fi); > fib_info_put(fib_work->fen_info.fi); > break; > - case FIB_EVENT_NH_ADD: /* fall through */ > + case FIB_EVENT_NH_ADD: > case FIB_EVENT_NH_DEL: > fib_nh = fib_work->fnh_info.fib_nh; > mlx5_lag_fib_nexthop_event(ldev, > @@ -256,7 +256,7 @@ static int mlx5_lag_fib_event(struct notifier_block *nb, > return NOTIFY_DONE; > > switch (event) { > - case FIB_EVENT_ENTRY_REPLACE: /* fall through */ > + case FIB_EVENT_ENTRY_REPLACE: > case FIB_EVENT_ENTRY_DEL: > fen_info = container_of(info, struct fib_entry_notifier_info, > info); > @@ -279,7 +279,7 @@ static int mlx5_lag_fib_event(struct notifier_block *nb, > */ > fib_info_hold(fib_work->fen_info.fi); > break; > - case FIB_EVENT_NH_ADD: /* fall through */ > + case FIB_EVENT_NH_ADD: > case FIB_EVENT_NH_DEL: > fnh_info = container_of(info, struct fib_nh_notifier_info, > info); > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/vport.c b/drivers/net/ethernet/mellanox/mlx5/core/vport.c > index 1faac31f..aea1065 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/vport.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/vport.c > @@ -125,7 +125,7 @@ void mlx5_query_min_inline(struct mlx5_core_dev *mdev, > case MLX5_CAP_INLINE_MODE_VPORT_CONTEXT: > if (!mlx5_query_nic_vport_min_inline(mdev, 0, min_inline_mode)) > break; > - /* fall through */ > + fallthrough; > case MLX5_CAP_INLINE_MODE_L2: > *min_inline_mode = MLX5_INLINE_MODE_L2; > break; > -- > 2.24.0 > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-03-12 19:54 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1583896344.git.joe@perches.com>
2020-03-11 4:51 ` [PATCH -next 001/491] MELLANOX ETHERNET INNOVA DRIVERS: Use fallthrough; Joe Perches
2020-03-11 7:01 ` Leon Romanovsky
2020-03-12 6:23 ` David Miller
2020-03-12 6:26 ` Joe Perches
2020-03-12 8:03 ` David Miller
2020-03-12 19:45 ` Jakub Kicinski
2020-03-12 19:52 ` Joe Perches
2020-03-11 4:51 ` [PATCH -next 003/491] MELLANOX MLX5 core VPI driver: " Joe Perches
2020-03-11 7:00 ` Leon Romanovsky
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox