From: Leon Romanovsky <leon@kernel.org>
To: Gal Pressman <galpress@amazon.com>
Cc: liweihang <liweihang@huawei.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: Question about IB_QP_CUR_STATE
Date: Wed, 8 Jul 2020 18:44:34 +0300 [thread overview]
Message-ID: <20200708154434.GA1276673@unreal> (raw)
In-Reply-To: <881488e6-03d8-1e01-076c-5c901d84a44a@amazon.com>
On Wed, Jul 08, 2020 at 03:42:34PM +0300, Gal Pressman wrote:
> On 08/07/2020 12:41, liweihang wrote:
> > Hi all,
> >
> > I'm a little confused about the role of IB_QP_CUR_STATE in the enumeration
> > ib_qp_attr_mask.
> >
> > In manual page of ibv_modify_qp(), comments of cur_qp_state is "Assume this
> > is the current QP state". Why we need to get current qp state from users
> > instead of drivers?
> >
> > For example, why the users are allowed to modify qp from RTR to RTS again
> > even if the qp's state in driver and hardware has already been RTS.
> >
> > I would be appretiate it if someone can help with this.
> >
> > Weihang
> >
>
> Talking about IB_QP_CUR_STATE, I see many drivers filling it in their query QP
> callback although it should only be used in modify operations.. Is there a
> reason not to remove it?
IBTA section "11.2.5.3 QUERY QUEUE PAIR" has line about IB_QP_CUR_STATE.
It is one of output modifiers.
Thanks
next prev parent reply other threads:[~2020-07-08 15:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 9:41 Question about IB_QP_CUR_STATE liweihang
2020-07-08 12:20 ` Leon Romanovsky
2020-07-08 12:42 ` Gal Pressman
2020-07-08 15:44 ` Leon Romanovsky [this message]
2020-07-09 6:13 ` Gal Pressman
2020-07-10 10:11 ` liweihang
2020-07-12 10:44 ` Leon Romanovsky
2020-07-12 10:53 ` Gal Pressman
2020-07-12 11:01 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708154434.GA1276673@unreal \
--to=leon@kernel.org \
--cc=galpress@amazon.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liweihang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox