From: "hch@lst.de" <hch@lst.de>
To: Parav Pandit <parav@nvidia.com>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
"mike.marciniszyn@cornelisnetworks.com"
<mike.marciniszyn@cornelisnetworks.com>,
"dledford@redhat.com" <dledford@redhat.com>,
Yanjun Zhu <yanjunz@nvidia.com>,
"bmt@zurich.ibm.com" <bmt@zurich.ibm.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"hch@lst.de" <hch@lst.de>,
"syzbot+34dc2fea3478e659af01@syzkaller.appspotmail.com"
<syzbot+34dc2fea3478e659af01@syzkaller.appspotmail.com>
Subject: Re: [PATCH] RDMA: Fix software RDMA drivers for dma mapping error
Date: Fri, 30 Oct 2020 16:01:15 +0100 [thread overview]
Message-ID: <20201030150115.GA15733@lst.de> (raw)
In-Reply-To: <BY5PR12MB43221AFDF37580F944C13967DC150@BY5PR12MB4322.namprd12.prod.outlook.com>
On Fri, Oct 30, 2020 at 12:45:45PM +0000, Parav Pandit wrote:
> Christoph did say 64-bit good enough, but he mentioned that it is not correct on 32-bit platforms.
> So it is only for theoretical correctness.
>
> > Technically there isn't. We are already dependent on 64bit config anyway.
> > Mike M just brought this up in a side bar conversation actually.
> For rvt driver, I should drop the check and always set to 64-bit.
Strictly speaking a dma_addr_t that is just the kernel virtual address
will never be larger than 32-bit on a 32-bit platform (by definition).
But setting it to 64 is entirely harmless, as we can't generate a larger
one (also by definition).
next prev parent reply other threads:[~2020-10-30 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 9:38 [PATCH] RDMA: Fix software RDMA drivers for dma mapping error Parav Pandit
2020-10-30 9:48 ` Guoqing Jiang
2020-10-30 12:04 ` Dennis Dalessandro
2020-10-30 12:17 ` Jason Gunthorpe
2020-10-30 12:19 ` Dennis Dalessandro
2020-10-30 12:45 ` Parav Pandit
2020-10-30 15:01 ` hch [this message]
2020-10-30 15:01 ` Christoph Hellwig
2020-11-01 4:28 ` Zhu Yanjun
2020-11-01 9:20 ` Zhu Yanjun
2020-11-02 19:20 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030150115.GA15733@lst.de \
--to=hch@lst.de \
--cc=bmt@zurich.ibm.com \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=parav@nvidia.com \
--cc=syzbot+34dc2fea3478e659af01@syzkaller.appspotmail.com \
--cc=yanjunz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox