From: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Parav Pandit <parav@nvidia.com>
Cc: mike.marciniszyn@cornelisnetworks.com, dledford@redhat.com,
yanjunz@nvidia.com, bmt@zurich.ibm.com,
linux-rdma@vger.kernel.org, hch@lst.de,
syzbot+34dc2fea3478e659af01@syzkaller.appspotmail.com
Subject: Re: [PATCH] RDMA: Fix software RDMA drivers for dma mapping error
Date: Fri, 30 Oct 2020 08:19:56 -0400 [thread overview]
Message-ID: <71c2013a-e9af-470c-9fae-30fc0cf78ee3@cornelisnetworks.com> (raw)
In-Reply-To: <20201030121731.GA36674@ziepe.ca>
On 10/30/2020 8:17 AM, Jason Gunthorpe wrote:
> On Fri, Oct 30, 2020 at 11:38:03AM +0200, Parav Pandit wrote:
>> @@ -1140,7 +1141,10 @@ int rxe_register_device(struct rxe_dev *rxe, const char *ibdev_name)
>> rxe->ndev->dev_addr);
>> dev->dev.dma_parms = &rxe->dma_parms;
>> dma_set_max_seg_size(&dev->dev, UINT_MAX);
>> - dma_set_coherent_mask(&dev->dev, dma_get_required_mask(&dev->dev));
>> + dma_mask = IS_ENABLED(CONFIG_64BIT) ? DMA_BIT_MASK(64) : DMA_BIT_MASK(32);
>> + err = dma_coerce_mask_and_coherent(&dev->dev, dma_mask);
>
> Since this mask doesn't actually do anything, what is the reason to
> have the 64/32?
Technically there isn't. We are already dependent on 64bit config
anyway. Mike M just brought this up in a side bar conversation actually.
-Denny
next prev parent reply other threads:[~2020-10-30 12:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 9:38 [PATCH] RDMA: Fix software RDMA drivers for dma mapping error Parav Pandit
2020-10-30 9:48 ` Guoqing Jiang
2020-10-30 12:04 ` Dennis Dalessandro
2020-10-30 12:17 ` Jason Gunthorpe
2020-10-30 12:19 ` Dennis Dalessandro [this message]
2020-10-30 12:45 ` Parav Pandit
2020-10-30 15:01 ` hch
2020-10-30 15:01 ` Christoph Hellwig
2020-11-01 4:28 ` Zhu Yanjun
2020-11-01 9:20 ` Zhu Yanjun
2020-11-02 19:20 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71c2013a-e9af-470c-9fae-30fc0cf78ee3@cornelisnetworks.com \
--to=dennis.dalessandro@cornelisnetworks.com \
--cc=bmt@zurich.ibm.com \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
--cc=parav@nvidia.com \
--cc=syzbot+34dc2fea3478e659af01@syzkaller.appspotmail.com \
--cc=yanjunz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox