* [PATCH] RDMA/siw: fix wrong judgment in siw_cm_work_handler
@ 2020-10-28 12:25 Zhang Qilong
2020-10-29 7:21 ` Bernard Metzler
2020-11-02 19:28 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Zhang Qilong @ 2020-10-28 12:25 UTC (permalink / raw)
To: bmt, dledford, jgg; +Cc: linux-rdma
The rv cannot be 'EAGAIN' in the previous path, we
should use '-EAGAIN' to check it. For example:
Call trace:
->siw_cm_work_handler
->siw_proc_mpareq
->siw_recv_mpa_rr
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
drivers/infiniband/sw/siw/siw_cm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/siw/siw_cm.c b/drivers/infiniband/sw/siw/siw_cm.c
index 66764f7ef072..1f9e15b71504 100644
--- a/drivers/infiniband/sw/siw/siw_cm.c
+++ b/drivers/infiniband/sw/siw/siw_cm.c
@@ -1047,7 +1047,7 @@ static void siw_cm_work_handler(struct work_struct *w)
cep->state);
}
}
- if (rv && rv != EAGAIN)
+ if (rv && rv != -EAGAIN)
release_cep = 1;
break;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/siw: fix wrong judgment in siw_cm_work_handler
2020-10-28 12:25 [PATCH] RDMA/siw: fix wrong judgment in siw_cm_work_handler Zhang Qilong
@ 2020-10-29 7:21 ` Bernard Metzler
2020-11-02 19:28 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Bernard Metzler @ 2020-10-29 7:21 UTC (permalink / raw)
To: Zhang Qilong; +Cc: dledford, jgg, linux-rdma
-----"Zhang Qilong" <zhangqilong3@huawei.com> wrote: -----
>To: <bmt@zurich.ibm.com>, <dledford@redhat.com>, <jgg@ziepe.ca>
>From: "Zhang Qilong" <zhangqilong3@huawei.com>
>Date: 10/28/2020 10:44PM
>Cc: <linux-rdma@vger.kernel.org>
>Subject: [EXTERNAL] [PATCH] RDMA/siw: fix wrong judgment in
>siw_cm_work_handler
>
>The rv cannot be 'EAGAIN' in the previous path, we
>should use '-EAGAIN' to check it. For example:
>
>Call trace:
>->siw_cm_work_handler
> ->siw_proc_mpareq
> ->siw_recv_mpa_rr
>
>Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
>---
> drivers/infiniband/sw/siw/siw_cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/infiniband/sw/siw/siw_cm.c
>b/drivers/infiniband/sw/siw/siw_cm.c
>index 66764f7ef072..1f9e15b71504 100644
>--- a/drivers/infiniband/sw/siw/siw_cm.c
>+++ b/drivers/infiniband/sw/siw/siw_cm.c
>@@ -1047,7 +1047,7 @@ static void siw_cm_work_handler(struct
>work_struct *w)
> cep->state);
> }
> }
>- if (rv && rv != EAGAIN)
>+ if (rv && rv != -EAGAIN)
> release_cep = 1;
> break;
>
>--
>2.17.1
>
>
Thanks Zhang, good catch!
Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] RDMA/siw: fix wrong judgment in siw_cm_work_handler
2020-10-28 12:25 [PATCH] RDMA/siw: fix wrong judgment in siw_cm_work_handler Zhang Qilong
2020-10-29 7:21 ` Bernard Metzler
@ 2020-11-02 19:28 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2020-11-02 19:28 UTC (permalink / raw)
To: Zhang Qilong; +Cc: bmt, dledford, linux-rdma
On Wed, Oct 28, 2020 at 08:25:09PM +0800, Zhang Qilong wrote:
> The rv cannot be 'EAGAIN' in the previous path, we
> should use '-EAGAIN' to check it. For example:
>
> Call trace:
> ->siw_cm_work_handler
> ->siw_proc_mpareq
> ->siw_recv_mpa_rr
>
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> Reviewed-by: Bernard Metzler <bmt@zurich.ibm.com>
> ---
> drivers/infiniband/sw/siw/siw_cm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-02 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-28 12:25 [PATCH] RDMA/siw: fix wrong judgment in siw_cm_work_handler Zhang Qilong
2020-10-29 7:21 ` Bernard Metzler
2020-11-02 19:28 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox