Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	linux-rdma@vger.kernel.org, linux-pci@vger.kernel.org,
	iommu@lists.linux-foundation.org
Subject: remove dma_virt_ops
Date: Wed,  4 Nov 2020 10:50:47 +0100	[thread overview]
Message-ID: <20201104095052.1222754-1-hch@lst.de> (raw)

Hi Jason,

this series switches the RDMA core to opencode the special case of
devices bypassing the DMA mapping in the RDMA ULPs.  The virt ops
have caused a bit of trouble due to the P2P code node working with
them due to the fact that we'd do two dma mapping iterations for a
single I/O, but also are a bit of layering violation and lead to
more code than necessary.

Tested with nvme-rdma over rxe.

Diffstat:
 b/drivers/infiniband/core/device.c      |   41 +++++++-------
 b/drivers/infiniband/core/rw.c          |    2 
 b/drivers/infiniband/sw/rdmavt/Kconfig  |    3 -
 b/drivers/infiniband/sw/rdmavt/mr.c     |    6 --
 b/drivers/infiniband/sw/rdmavt/vt.c     |    8 --
 b/drivers/infiniband/sw/rxe/Kconfig     |    2 
 b/drivers/infiniband/sw/rxe/rxe_verbs.c |    7 --
 b/drivers/infiniband/sw/rxe/rxe_verbs.h |    1 
 b/drivers/infiniband/sw/siw/Kconfig     |    1 
 b/drivers/infiniband/sw/siw/siw.h       |    1 
 b/drivers/infiniband/sw/siw/siw_main.c  |    7 --
 b/drivers/pci/p2pdma.c                  |   25 ---------
 b/include/linux/dma-mapping.h           |    2 
 b/include/rdma/ib_verbs.h               |   88 ++++++++++++++------------------
 b/kernel/dma/Kconfig                    |    5 -
 b/kernel/dma/Makefile                   |    1 
 kernel/dma/virt.c                       |   61 ----------------------
 17 files changed, 66 insertions(+), 195 deletions(-)

             reply	other threads:[~2020-11-04  9:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04  9:50 Christoph Hellwig [this message]
2020-11-04  9:50 ` [PATCH 1/5] RDMA/core: remove ib_dma_{alloc,free}_coherent Christoph Hellwig
2020-11-04  9:50 ` [PATCH 2/5] RDMA/core: remove use of dma_virt_ops Christoph Hellwig
2020-11-04 13:42   ` Jason Gunthorpe
2020-11-04 14:01     ` Christoph Hellwig
2020-11-04 15:09       ` Bernard Metzler
2020-11-04 18:10         ` Jason Gunthorpe
2020-11-04 15:52       ` Jason Gunthorpe
2020-11-04 16:31         ` Christoph Hellwig
2020-11-04 18:09           ` Jason Gunthorpe
2020-11-04  9:50 ` [PATCH 3/5] PCI/p2p: remove the DMA_VIRT_OPS hacks Christoph Hellwig
2020-11-04 16:53   ` Bjorn Helgaas
2020-11-04 17:00   ` Logan Gunthorpe
2020-11-04  9:50 ` [PATCH 4/5] PCI/p2p: cleanup up __pci_p2pdma_map_sg a bit Christoph Hellwig
2020-11-04 16:54   ` Bjorn Helgaas
2020-11-04  9:50 ` [PATCH 5/5] dma-mapping: remove dma_virt_ops Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201104095052.1222754-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=bhelgaas@google.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=logang@deltatee.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox